Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oep:(cspc,cspi,day2ops) propose schema changes for pool resources and workflow for day 2 ops #2595

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

sonasingh46
Copy link
Contributor

@sonasingh46 sonasingh46 commented May 27, 2019

CStor Resources Schema Proposal

This PR proposes a schema change for the custom resources that are used for CStor pool provisioning.

The doc should be read in the following order:

  1. intro.md
  2. spec.md
  3. provisioning.md
  4. day2ops.md
  5. upgrade.md

Signed-off-by: Ashutosh Kumar ashutosh.kumar@openebs.io

contribute/design/cstor-operator/specs.md Outdated Show resolved Hide resolved
contribute/design/cstor-operator/specs.md Outdated Show resolved Hide resolved
contribute/design/cstor-operator/specs.md Outdated Show resolved Hide resolved
contribute/design/cstor-operator/specs.md Outdated Show resolved Hide resolved
contribute/design/cstor-operator/specs.md Outdated Show resolved Hide resolved
contribute/design/cstor-operator/specs.md Outdated Show resolved Hide resolved
contribute/design/cstor-operator/specs.md Outdated Show resolved Hide resolved
contribute/design/cstor-operator/specs.md Outdated Show resolved Hide resolved
Copy link
Contributor

@vishnuitta vishnuitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please provide CSP schema changes as well

@sonasingh46 sonasingh46 force-pushed the spec_design branch 4 times, most recently from 2ac3010 to 9fb1a12 Compare May 28, 2019 12:02
contribute/design/cstor-operator/specs.md Outdated Show resolved Hide resolved
contribute/design/cstor-operator/specs.md Outdated Show resolved Hide resolved
contribute/design/cstor-operator/specs.md Outdated Show resolved Hide resolved
contribute/design/cstor-operator/specs.md Outdated Show resolved Hide resolved
@sonasingh46 sonasingh46 force-pushed the spec_design branch 2 times, most recently from a03ce44 to 947025e Compare May 29, 2019 11:10
Copy link
Contributor

@vishnuitta vishnuitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below are review comments from discussion between Ashutosh, me and Kiran:

  • move 'poolSpec' from spec.nodes to spec (as per Kiran's comments
  • there are too many 'name' fields in spec.nodes which would be confusing. So, make them more explanatory.
    cc: @AmitKumarDas

@vishnuitta vishnuitta changed the title [WIP]design:(CStor-resources-schema) propose schema changes for CStor resources. design:(CStor-resources-schema) propose schema changes for CStor resources. May 30, 2019
contribute/design/cstor-operator/day2ops.md Outdated Show resolved Hide resolved
contribute/design/cstor-operator/day2ops.md Outdated Show resolved Hide resolved
contribute/design/cstor-operator/day2ops.md Outdated Show resolved Hide resolved
Copy link

@AmitKumarDas AmitKumarDas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Approved CSPC schema!!!

Copy link

@mittachaitu mittachaitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoProvisioning of pool creation is supported via storagepoolclaim
When user creates auto spc spc-controller will internally converts the spc to cspc so pool creations will be handled by cspc controller.
Example spc:

apiVersion: openebs.io/v1alpha1
kind: StoragePoolClaim
metadata:
  name: cstor-sparse
spec:
  name: cstor-sparse
  type: sparse
  poolSpec:
    poolType: striped
    cacheFile: /tmp/pool1.cache
  maxPools: 1

when user created above spc spc-controller will convert to cspc.
High level steps for converting spc to cspc:

  1. Build and create cspc from spc provided by the user.
  2. Add finalizers on spc.

Deletion of cspc:

  1. User should delete spc to delete cspc and pools

Internal work flow by spc controller:
Finalizers on spc will make sure below steps

  1. Remove finalizers on cspc.
  2. Delete corresponding cspc.
  3. Remove finalizers on spc.

@sonasingh46 sonasingh46 changed the title [WIP]design:(CStor-resources-schema) propose schema changes for CStor resources. [WIP]oep:(cspc) propose schema changes for CStor resources. Jul 16, 2019
@sonasingh46 sonasingh46 changed the title [WIP]oep:(cspc) propose schema changes for CStor resources. oep:(cspc,csp,day2ops) propose schema changes for pool resources and workflow for day 2 ops Jul 19, 2019
@sonasingh46 sonasingh46 force-pushed the spec_design branch 2 times, most recently from c39c0d3 to a3bc584 Compare July 19, 2019 10:03
…urces

Signed-off-by: Ashutosh Kumar <ashutosh.kumar@openebs.io>
@kmova kmova merged commit aa66d39 into openebs:master Sep 4, 2019
@sonasingh46 sonasingh46 changed the title oep:(cspc,csp,day2ops) propose schema changes for pool resources and workflow for day 2 ops oep:(cspc,cspi,day2ops) propose schema changes for pool resources and workflow for day 2 ops Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants