Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(upgrade): Add upgrade script for upgrading jiva volumes from 0.6 to 0.8.1 #2468

Merged
merged 3 commits into from
Mar 31, 2019

Conversation

ashishranjan738
Copy link
Contributor

Signed-off-by: Ashish Ranjan ashishranjan738@gmail.com

This commit adds the scripts for upgrading jiva volumes from 0.6 to 0.8.1.

@kmova kmova added the Review Must review label Mar 28, 2019
**The sample steps below will work if you have installed openebs with default values provided by stable/openebs helm chart.**

- Run `helm repo update` to update local cache with latest package
- Run `helm ls` to get the release name of openebs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to change any helm upgrade steps here @prateekpandey14 ?

Copy link

@rgembalik rgembalik Mar 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update from 0.5.0 had values suggested during update process (see .../0.5.x-0.6.0 README and ...helm-values-0.6.0.yaml ). If anyone updated previously using those steps, he'll have all values outdated.

I'd at least mention that, or even add --reset-values into the upgrade for those who applied values above. Otherwise upgrade will pass, but many image tags will stay at 0.6.0.

Copy link
Member

@kmova kmova Mar 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rgembalik for reviewing! How about adding the following note.


Before upgrading using helm, please review the default values available with latest stable/openebs chart. (https://raw.githubusercontent.com/helm/charts/master/stable/openebs/values.yaml).

  • If the default values seem appropriate, you can use the helm upgrade --reset-values <release name> stable/openebs.
  • If not, customize the values into your copy (say custom-values.yaml), by copying the content from above default yamls and edit the values to suite your environment. You can upgrade using your custom values using:
    helm upgrade <release name> stable/openebs -f custom-values.yaml

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I am 99% sure that it should say helm upgrade --reset-values <release name> stable/openebs instead of helm upgrade --reset <release name> stable/openebs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! you are right.

@ashishranjan738 ashishranjan738 force-pushed the 0.6 branch 4 times, most recently from 986796d to f880151 Compare March 29, 2019 14:46
…0.6 to 0.8.1

Signed-off-by: Ashish Ranjan <ashishranjan738@gmail.com>

This commit adds script for upgrading jiva volumes from 0.6 to 0.8.1
Signed-off-by: Ashish Ranjan <ashishranjan738@gmail.com>
Copy link
Contributor

@vishnuitta vishnuitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good.. dropped few comments for sake of correctness
Even if not fixed, conditions that are later will take care of it.

kubectl annotate pv $pv openebs.io/cas-type=jiva

controller_version=`kubectl get deployment $c_dep -n $ns -o jsonpath='{.metadata.labels.openebs\.io/version}'`
if [[ "$controller_version" == "$target_upgrade_version" ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good one to have this check 👍

Signed-off-by: Ashish Ranjan <ashishranjan738@gmail.com>
Copy link
Contributor

@vishnuitta vishnuitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good

@vishnuitta vishnuitta merged commit 38437c8 into openebs:master Mar 31, 2019
@kmova kmova removed the Review Must review label Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants