-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(upgrade): Add upgrade script for upgrading jiva volumes from 0.6 to 0.8.1 #2468
Conversation
**The sample steps below will work if you have installed openebs with default values provided by stable/openebs helm chart.** | ||
|
||
- Run `helm repo update` to update local cache with latest package | ||
- Run `helm ls` to get the release name of openebs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to change any helm upgrade steps here @prateekpandey14 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update from 0.5.0 had values suggested during update process (see .../0.5.x-0.6.0 README and ...helm-values-0.6.0.yaml ). If anyone updated previously using those steps, he'll have all values outdated.
I'd at least mention that, or even add --reset-values
into the upgrade for those who applied values above. Otherwise upgrade will pass, but many image tags will stay at 0.6.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rgembalik for reviewing! How about adding the following note.
Before upgrading using helm, please review the default values available with latest stable/openebs chart. (https://raw.githubusercontent.com/helm/charts/master/stable/openebs/values.yaml).
- If the default values seem appropriate, you can use the
helm upgrade --reset-values <release name> stable/openebs
. - If not, customize the values into your copy (say
custom-values.yaml
), by copying the content from above default yamls and edit the values to suite your environment. You can upgrade using your custom values using:
helm upgrade <release name> stable/openebs -f custom-values.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, although I am 99% sure that it should say helm upgrade --reset-values <release name> stable/openebs
instead of helm upgrade --reset <release name> stable/openebs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! you are right.
986796d
to
f880151
Compare
…0.6 to 0.8.1 Signed-off-by: Ashish Ranjan <ashishranjan738@gmail.com> This commit adds script for upgrading jiva volumes from 0.6 to 0.8.1
Signed-off-by: Ashish Ranjan <ashishranjan738@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are good.. dropped few comments for sake of correctness
Even if not fixed, conditions that are later will take care of it.
kubectl annotate pv $pv openebs.io/cas-type=jiva | ||
|
||
controller_version=`kubectl get deployment $c_dep -n $ns -o jsonpath='{.metadata.labels.openebs\.io/version}'` | ||
if [[ "$controller_version" == "$target_upgrade_version" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good one to have this check 👍
Signed-off-by: Ashish Ranjan <ashishranjan738@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are good
Signed-off-by: Ashish Ranjan ashishranjan738@gmail.com
This commit adds the scripts for upgrading jiva volumes from 0.6 to 0.8.1.