feat(install): setup liveness probes for openebs components #1909
Conversation
Signed-off-by: kmova <kiran.mova@openebs.io>
| command: | ||
| - /usr/local/bin/mayactl | ||
| - version | ||
| initialDelaySeconds: 300 |
There was a problem hiding this comment.
Can Initialdelayseconds be shortened (60 or less) , otherwise looks good to me.
There was a problem hiding this comment.
keeping it too low may cause false positives on a slow network.
| command: | ||
| - pgrep | ||
| - ".*provisioner" | ||
| initialDelaySeconds: 300 |
There was a problem hiding this comment.
Can Initialdelayseconds be shortened (60 or less)? otherwise looks good to me.
| command: | ||
| - pgrep | ||
| - ".*controller" | ||
| initialDelaySeconds: 300 |
There was a problem hiding this comment.
Can Initialdelayseconds be shortened (60 or less)? otherwise looks good to me.
| command: | ||
| - pgrep | ||
| - ".*provisioner" | ||
| initialDelaySeconds: 300 |
There was a problem hiding this comment.
Can Initialdelayseconds be shortened (60 or less)? otherwise looks good to me.
| command: | ||
| - pgrep | ||
| - ".*ndm" | ||
| initialDelaySeconds: 300 |
There was a problem hiding this comment.
Can initialDelaySeconds be shortened (60 or less)? otherwise looks good to me.
| @@ -156,6 +156,13 @@ spec: | |||
| value: "openebs/cstor-volume-mgmt:ci" | |||
| - name: OPENEBS_IO_VOLUME_MONITOR_IMAGE | |||
| value: "openebs/m-exporter:ci" | |||
| livenessProbe: | |||
There was a problem hiding this comment.
Separately, can we use the same ExecAction to add readinessProbe?
There was a problem hiding this comment.
Yes. It does help to add a readinessProbe to maya-apiserver deployment, since it is frontended by a service.
Signed-off-by: kmova <kiran.mova@openebs.io>
|
LGTM |
This PR adds liveness probes to check the required binaries are running within the control plane components. In the future, these can be enhanced to check for additional parameters.
Signed-off-by: kmova kiran.mova@openebs.io