Adds ENV variables to connect to K8s APIs #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Why is this change necessary ? This lets maya api service & openebs provisioner connect to K8s APIs based on K8s Master address or KubeConfig. These ENV variables are optional. 2. How does this change address the issue ? - Adds ENV to specs - OPENEBS_IO_KUBE_CONFIG - OPENEBS_IO_K8S_MASTER 3. How to verify this change ? - Refer to the comments specified in the specs 4. What side effects does this change have ? - This will let the services connect to K8s using either of above ENV variables. Signed-off-by: amitkumardas <amit.das@openebs.io>
ksatchit
approved these changes
Feb 7, 2018
prateekpandey14
approved these changes
Feb 7, 2018
kmova
approved these changes
Feb 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets maya api service & openebs provisioner connect to
K8s APIs based on K8s Master address or KubeConfig.
These ENV variables are optional.
either of above ENV variables.
Signed-off-by: amitkumardas amit.das@openebs.io
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: