Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(upgrade): expose modules to pub scope #580

Merged
merged 1 commit into from
Dec 13, 2024
Merged

refactor(upgrade): expose modules to pub scope #580

merged 1 commit into from
Dec 13, 2024

Conversation

niladrih
Copy link
Member

@niladrih niladrih commented Dec 9, 2024

This is a refactor which moves most of the upgrade-job 'bin' code to the upgrade lib, and expands its visibility scope from 'pub(crate)' to 'pub'.

tiagolobocastro
tiagolobocastro reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remind me again, is this for the unified plugin or to allow for more binaries?

k8s/upgrade/src/helm/chart.rs Outdated Show resolved Hide resolved
k8s/upgrade/src/upgrade_path.rs Outdated Show resolved Hide resolved
@niladrih
Copy link
Member Author

Remind me again, is this for the unified plugin or to allow for more binaries?

This is for the unified plugin, which will be a new binary.

@tiagolobocastro
Copy link
Contributor

Remind me again, is this for the unified plugin or to allow for more binaries?

This is for the unified plugin, which will be a new binary.

Does it need this big public api surface exposed or can we expose minimal api and leave internal details here?

@niladrih
Copy link
Member Author

Remind me again, is this for the unified plugin or to allow for more binaries?

This is for the unified plugin, which will be a new binary.

Does it need this big public api surface exposed or can we expose minimal api and leave internal details here?

Hmm... sure, I'll trim this down. All of this doesn't need to be in pub scope. 👍

@niladrih niladrih marked this pull request as draft December 11, 2024 08:33
@niladrih niladrih marked this pull request as ready for review December 12, 2024 19:03
@niladrih
Copy link
Member Author

@tiagolobocastro -- I've removed 2nd and 3rd level APIs and only exposed 1st level APIs. I've also hidden APIs which we've decided to not carry over to the unified upgrade, by design.

@niladrih
Copy link
Member Author

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Dec 13, 2024
@niladrih
chore(bors): merge pull request #580
4158b46 
580: refactor(upgrade): expose modules to pub scope r=niladrih a=niladrih

This is a refactor which moves most of the upgrade-job 'bin' code to the upgrade lib, and expands its visibility scope from 'pub(crate)' to 'pub'.

Co-authored-by: Niladri Halder <niladri.halder26@gmail.com>
@bors-openebs-mayastor
Copy link
Contributor

Build failed:

@niladrih
refactor(upgrade): expose modules to pub scope
323b4e3 
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
@niladrih
Copy link
Member Author

bors merge

@bors-openebs-mayastor
Copy link
Contributor

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 23b4d82 into develop Dec 13, 2024
7 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the bin-to-lib branch December 13, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinhaashish sinhaashish sinhaashish approved these changes

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@Abhinandan-Purkait Abhinandan-Purkait Awaiting requested review from Abhinandan-Purkait

@abhilashshetty04 abhilashshetty04 Awaiting requested review from abhilashshetty04

@dsharma-dc dsharma-dc Awaiting requested review from dsharma-dc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niladrih @tiagolobocastro @sinhaashish