fix(upgrade-job): fix deserialize failures with helm v3.13+ installations #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niladrih
requested review from
tiagolobocastro,
sinhaashish and
Abhinandan-Purkait
|
Fixes openebs/openebs#3720. |
Abhinandan-Purkait
approved these changes
Jun 11, 2024
…ions With helm v3.13+ if loki-stack or jaeger-operator is disabled, helm chart values deserialize fails. This change adds default deserialize options, so that the necessary options may still be set even if the dependent charts are disabled. Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
force-pushed
the
upgrade-dep-charts
branch
from
dbf8f08 to
8888574
Compare
tiagolobocastro
approved these changes
Jun 14, 2024
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With helm v3.13+ if loki-stack or jaeger-operator is disabled, helm chart values deserialize fails. This change adds default deserialize options, so that the necessary options may still be set even if the dependent charts are disabled.