chore: add MAINTAINERS #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avishnu
approved these changes
Apr 23, 2024
orville-wright
added
Community
edrob999
suggested changes
Apr 23, 2024
There was a problem hiding this comment.
- Please replace lines 3-6 with this rewording:
# OpenEBS is an umbrella project, composed as a federation of individual sub projects (repositories).
# THIS MAINTAINERS FILE APPLIES TO THE UMBRELLA PROJECT, EVERY SUB-PROJECT, REPOSITORY AND FILE IN THE OPENEBS ORGANIZATION.
# THIS MAINTAINERS FILE SUPERSEDES AND OVERRIDES ALL OTHER MAINTAINERS FILES. - Remove 2 files: maintainers, maintainers.old from openebs/openebs repo
There was a problem hiding this comment.
New file location is correct
-
Wording may be slightly off as Ed has some specific language for this file. Please check with his review.
-
Need to delete the original MAINTAINERS and MAINTAINERS_OLD files from openebs/openebs parent repo as Ed's strategy is to only have 1 instance of MAINTAINERS file across the entire org, project and all repos.
-
Not sure if the deletion will be done in a separate PR ?
-
All instances of MAINTAINERS files needs to be deleted when this file goes live.
orville-wright
approved these changes
Apr 23, 2024
dave-brace
approved these changes
Apr 23, 2024
tiagolobocastro
force-pushed
the
maintainers
branch
from
7e35604 to
e4d2b6f
Compare
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
tiagolobocastro
force-pushed
the
maintainers
branch
from
e4d2b6f to
cde9d59
Compare
tiagolobocastro
commented
Apr 25, 2024
There was a problem hiding this comment.
@edrob999, updated PTAL
Also should we include email addresses as well
|
signed-off-by: Ed Robinson ed.robinson@gmail.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.