Fix bias in HoughLines with even number of rho discretization steps #25038 #25043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmorkalov
reviewed
Feb 19, 2024
| @@ -34,3 +34,4 @@ Please read the [contribution guidelines](https://github.com/opencv/opencv/wiki/ | |||
| * [Follow OpenCV on Mastodon](http://mastodon.social/@opencv) in the Fediverse | |||
| * [Follow OpenCV on Twitter](https://twitter.com/opencvlive) | |||
| * [OpenCV.ai](https://opencv.ai): Computer Vision and AI development services from the OpenCV team. | |||
|
|
|||
There was a problem hiding this comment.
Please do not touch irrelevant files.
|
@Adi-gitX , thank you for the patch! Could you port the test from the issue to C++ and add it as OpenCV test to check that your fix is proper? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#25038
Description:
Replace the multiplication by 0.5f with a division by int(2) in the calculation of rho value to address potential bias in Hough Line Transform.
Changes Made:
Modified the calculation of the rho value in Hough Line Transform by changing the expression from
(r - (numrho - 1)*0.5f) * rhoto(r - (numrho - 1)/2) * rho.Purpose:
To fix a potential bias issue in the calculated rho values of detected lines in the Hough Line Transform.
Related Issue:
No specific issue tracked. This change addresses a potential issue identified in the codebase.
Additional Information:
This change has been tested locally and verified to resolve the bias issue in rho values without affecting the functionality of the Hough Line Transform.