Sth/expand cloud cost properties #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Holcomb <seanholcomb@gmail.com>
Sean-Holcomb
force-pushed
the
sth/expand-cloud-cost-properties
branch
from
19b844f
to
e686b32
Compare
avrodrigues5
approved these changes
Aug 6, 2024
core/pkg/filter/cloudcost/fields.go
Outdated
| FieldAccountID CloudCostField = CloudCostField(fieldstrings.FieldAccountID) | ||
| FieldAccountName CloudCostField = CloudCostField(fieldstrings.FieldAccountName) | ||
| FieldRegionID CloudCostField = CloudCostField(fieldstrings.FieldRegionID) | ||
| FieldAvailabilityZone = CloudCostField(fieldstrings.FieldAvailabilityZone) |
There was a problem hiding this comment.
Is there a particular reason why FieldAvailabilityZone doesnt have string alias
mbolt35
reviewed
Aug 6, 2024
| InvoiceEntityName string `json:"invoiceEntityName,omitempty"` // @bingen:field[version=3] | ||
| RegionID string `json:"regionID,omitempty"` // @bingen:field[version=3] | ||
| AvailabilityZone string `json:"availabilityZone,omitempty"` // @bingen:field[version=3] | ||
| Service string `json:"service,omitempty"` |
There was a problem hiding this comment.
I'm glad you're putting this into practice. I think for years, I've been preaching "add new fields to the end" but realized recently that this wasn't a requirement after the backwards compatibility updates.
Although, once this ordering is established, you can't rearrange afterwards. That's the only remaining nuance.
Signed-off-by: Sean Holcomb <seanholcomb@gmail.com>
qixiangyang
pushed a commit
to qixiangyang/opencost
that referenced
this pull request
Aug 13, 2024
* Update Cloud Cost with new properteis Signed-off-by: Sean Holcomb <seanholcomb@gmail.com> * Final changes and test Signed-off-by: Sean Holcomb <seanholcomb@gmail.com> --------- Signed-off-by: Sean Holcomb <seanholcomb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This PR adds 4 new properties to the Cloud Cost type that can be aggregated or filtered on. These new fields line up with FOCUS Spec fields bringing Cloud Costs closer to the spec The fields are:
To go along with these new properties, each billing integration implementation has been updated to ingest values for them if available. When values are not available for BillingEntityName or AccountName the value from BillingEntityID and AccountID are used respectively. If there is no RegionID or AvailabilityZone value then the properties are left blank.
This Pr also contains fixes for the S3Select integration for AWS.
Does this PR relate to any other PRs?
How will this PR impact users?
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
Does this PR require changes to documentation?
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?