Fix the issue where the prices for most Alibaba Cloud instance types are incorrect when the instance family generation number is greater than or equal to 7 #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qixiangyang
changed the title
|
Great catch! We'll have a look and see what we can do! |
ameijer
requested changes
Aug 12, 2024
|
also, please sign off on your code |
qixiangyang
force-pushed
the
develop
branch
3 times, most recently
from
0933442
to
cc07e66
Compare
ameijer
requested changes
Aug 13, 2024
…are incorrect when the instance family generation number is greater than or equal to 7. Update provider.go remove debug info Signed-off-by: qixiangyang <qixiangyangrm@foxmail.com>
…types. 2. Revise comments when system disk information is not available 3. Add error logging and optimize the return value for the 'getInstanceFamilyGenerationFromType' function. 4. Add test cases for generating node requests for various instance types. Signed-off-by: xiangyang.qi <xiangyang.qi@advancegroup.com> 1. Revise 'alibabaDefaultToCloudEssd' exclude 6+ generation instance types. 2. Revise comments when system disk information is not available 3. Add error logging and optimize the return value for the 'getInstanceFamilyGenerationFromType' function. 4. Add test cases for generating node requests for various instance types. Signed-off-by: qixiangyang <qixiangyangrm@foxmail.com>
Co-authored-by: Alex Meijer <ameijer@users.noreply.github.com> Signed-off-by: qixiangyang <qixiangyangrm@foxmail.com>
Signed-off-by: qixiangyang <qixiangyangrm@foxmail.com>
ameijer
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue where the prices for most Alibaba Cloud instance types are incorrect when the instance family generation number is greater than or equal to 7.
What does this PR change?
Does this PR relate to any other PRs?
How will this PR impact users?
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
Does this PR require changes to documentation?
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?