-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to GitHub Issues #1055
Move to GitHub Issues #1055
Conversation
:-( for all the boilerplate cut & paste text we have for the 500 errors. |
…ound for a while yet for various roles.
@gregorydlogan In |
@@ -22,9 +22,10 @@ this repository are explained later in this guide. | |||
|
|||
### Jira and GitHub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove Jira from the title of the section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep!
I'm going to miss the I'll fix these shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure if listing the issue tracker makes sense in all those Java files but I also have no strong opinion against it. I found a few other issues though.
We've also discussed the issue template in a session on the summit in Münster and there was a tendency to just having an empty free text field for describing the steps to reproduce the issue. But I don't have a strong opinion on that and we could just say that we try it and evaluate in two months if it works or if it doesn't. The same goes for the pull request template though I like the list of checkboxes.
* Opencast uses [GitHub](https://github.com/opencast/opencast/issues) for tracking issues. Each pull request should be | ||
accompanied by a ticket in GitHub. The issue identifier should also be used in the title of the pull request and the | ||
commits. E.g.: `#12345, Fixing Something Somewhere`. Creating a GitHub issue is usually the first step when fixing | ||
something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here:
- No hard requirement for issues
- The issue numbers shouldn't be included in the title but they should be referenced in the description (which will link issue and pull request) in a way that the issue is automatically closed in necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not read as a hard requirement to me (should
), but I'll make it clearer.
Known issue:
|
@gregorydlogan, I fixed a missing replacement for Jira in the security issue docs. The Jira feedback link mentioned in the org-config is actually fine like this since it's for adopters to attach their own Jira to the admin interface. So this is unrelated to Opencast's Jira. I figured I'll merge it like this. If other places pop up where we missed something, we can still patch that later. But I don't think we have missed anything (← famous last words ;-)). |
…elop Pull request #1055 NOISSUE: Move to GitHub Issues
This PR (finally!) moves our issue tracking over to GitHub. I will be enabling GH issues in a minute, and will lock JIRA and send out the notifications once this has been merged.