Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0.x.x] Duplicated array key - ec_ship.php #13438

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

condor2
Copy link
Contributor

@condor2 condor2 commented Jan 6, 2024

No description provided.

@TheCartpenter
Copy link
Contributor

Already fixed.

@condor2
Copy link
Contributor Author

condor2 commented Jan 6, 2024

Already fixed.

To bypass checking the file :)
https://github.com/opencart/opencart-3/blob/main/phpstan.neon#L23

@TheCartpenter
Copy link
Contributor

Already fixed.

To bypass checking the file :) https://github.com/opencart/opencart-3/blob/main/phpstan.neon#L23

That's related to something else in regard to the excluded file, not for this error. The suggested fix has been applied already. The reason why we believe it's fixed on the v3.0.x.x branch is because not all the rules as the MB and opencart-3 have been added the CS fixer. The error may, then, remain on the backend until deeper troubleshooting has been done without the specific parameters.

@danielkerr
Copy link
Member

can u update sagepay with opayo from the extension store. needs updating as they have discontinued the url.

@danielkerr danielkerr merged commit 217dac9 into opencart:3.0.x.x Jan 6, 2024
0 of 6 checks passed
@condor2 condor2 deleted the patch-7 branch January 6, 2024 21:14
@TheCartpenter
Copy link
Contributor

TheCartpenter commented Jan 6, 2024

can u update sagepay with opayo from the extension store. needs updating as they have discontinued the url.

Done: https://forum.opencart.com/viewtopic.php?p=865552#p865552 . Also published on the OC marketplace existing extension page.

@condor2
Copy link
Contributor Author

condor2 commented Jan 6, 2024

I think he want to be added in repo, and removed sagepay.

@TheCartpenter
Copy link
Contributor

I think he want to be added in repo, and removed sagepay.

Which sagepay? Direct, Server or both?

@condor2
Copy link
Contributor Author

condor2 commented Jan 6, 2024

I think both.
Never used this payment.
Also there are 2 modules Sagepay

Maybe @danielkerr know better.

@condor2
Copy link
Contributor Author

condor2 commented Jan 6, 2024

Paypal_express was removed..posible this will not work anymore

https://github.com/opencart/opencart/blob/3.0.x.x/upload/catalog/controller/extension/recurring/pp_express.php

@TheCartpenter
Copy link
Contributor

Paypal_express was removed..posible this will not work anymore

https://github.com/opencart/opencart/blob/3.0.x.x/upload/catalog/controller/extension/recurring/pp_express.php

Yes, correct. It has been removed when the first intro. of PayPal Checkout was added into the 3.0.x.x which is one of the reasons I fixed the PayPal Checkout extension in order to deal with recurring orders / subscriptions directly with PayPal for those who can since it has been provided by Opencart as a free extension as well on the OC Marketplace since quite sometime now.

@TheCartpenter
Copy link
Contributor

As for opayo, it has now been added to the opencart repo: opencart/opencart-3@805c476 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants