Default to a blank dsn if sentry env vars are not set #4963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… vars are not set
github-actions
bot
added
type: bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4963 +/- ##
============================================
- Coverage 7.67% 7.61% -0.06%
+ Complexity 829 816 -13
============================================
Files 600 600
Lines 42275 42275
Branches 10276 10277 +1
============================================
- Hits 3245 3221 -24
- Misses 38556 38586 +30
+ Partials 474 468 -6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: N/A
Description: Currently we see the following warning during startup when local testing:
10:13:50,850 |-WARN in io.sentry.logback.SentryAppender[sentry] - Failed to init Sentry during appender initialization: DSN is required. Use empty string or set enabled to false in SentryOptions to disable SDK.This also causes logback to dump a whole bunch of other debug logs.
The fix sets a default value of empty string (which disables Sentry) for the dsn if the SENTRY_DSN_BACKEND or SENTRY_DSN environment variables are not set.