Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new radio_locale parameter for Medtronic pumps #112

Merged
merged 1 commit into from
Dec 14, 2016

Conversation

oskarpearson
Copy link
Contributor

Add support for the 'radio_locale' medtronic parameter.

This helps make using oskarpearson/mmeowlink@3a8d867 easier.

@scottleibrand
Copy link
Contributor

What would be an example of the usage for this, so we can test it?

oskarpearson added a commit to oskarpearson/oref0 that referenced this pull request Dec 13, 2016
@oskarpearson
Copy link
Contributor Author

@scottleibrand openaps/oref0#276 uses it. Please let me know if you're happy with this structure.

This particular change will modify pump.ini to contain this:

[device "pump"]
serial = 123123
radio_locale = WW

mmeowlink will look for that parameter when doing mmtune etc as per oskarpearson/mmeowlink@3a8d867 (currently only in the dev branch - but having the value in the ini file won't break anything if it's not used)

@scottleibrand
Copy link
Contributor

Cool. Might be easiest to go ahead and merge this for testing. Does anyone see any reason not to do that?

oskarpearson added a commit to oskarpearson/oref0 that referenced this pull request Dec 13, 2016
@oskarpearson
Copy link
Contributor Author

I think that this can be merged. We could need to make additional changes, but from what I can tell it'll work as expected.

@scottleibrand scottleibrand merged commit ceac808 into openaps:dev Dec 14, 2016
scottleibrand pushed a commit to openaps/oref0 that referenced this pull request Dec 14, 2016
@scottleibrand
Copy link
Contributor

scottleibrand commented Dec 20, 2016

Per https://gitter.im/nightscout/intend-to-bolus?at=5858a0f6c5a4e0233ba7961c it doesn't appear that openaps device add pump mmeowlink subg_rfspy /dev/spidev5.1 <serial> WW ever adds the radio_locale = WW line to the pump.ini. Any ideas why not?

@PieterGit
Copy link

@scottleibrand and @oskarpearson : i think pull request needs still to be applied to an openaps release to be able to remove the workaround in the current oref0-setup.sh (currently on my devww branch, but statement is also available in oref0 master and dev)

      # Hack to check if radio_locale has been set in pump.ini. This is a temporary workaround for https://github.com/oskarpearson/mmeowlink/issues/55
      # It will remove empty line at the end of pump.ini and then append radio_locale if it's not there yet
      # TODO: remove once https://github.com/openaps/openaps/pull/112 has been released in a openaps version
      grep -q radio_locale pump.ini ||  echo "$(< pump.ini)" > pump.ini ; echo "radio_locale=$radio_locale" >> pump.ini

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants