Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: left pad jaeger trace ids #743

Merged
merged 5 commits into from
Feb 18, 2020
Merged

fix: left pad jaeger trace ids #743

merged 5 commits into from
Feb 18, 2020

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jan 29, 2020

Fixes #742

@dyladan dyladan added the bug Something isn't working label Jan 29, 2020
@codecov-io
Copy link

codecov-io commented Jan 29, 2020 •
edited
Loading

Codecov Report

Merging #743 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #743      +/-   ##
=========================================
+ Coverage   92.68%   92.7%   +0.01%     
=========================================
  Files         227     227              
  Lines       10366   10385      +19     
  Branches      929     930       +1     
=========================================
+ Hits         9608    9627      +19     
  Misses        758     758
Impacted Files Coverage Δ
...ges/opentelemetry-exporter-jaeger/src/transform.ts 100% <100%> (ø) ⬆️
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <100%> (ø) ⬆️
...y-tracing/test/export/InMemorySpanExporter.test.ts 100% <0%> (ø) ⬆️
...kages/opentelemetry-metrics/test/mocks/Exporter.ts 66.66% <0%> (-33.34%) ⬇️
...kages/opentelemetry-plugin-dns/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
...ages/opentelemetry-plugin-http/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
packages/opentelemetry-tracing/src/utility.ts 100% <0%> (ø) ⬆️
...es/opentelemetry-node/src/instrumentation/utils.ts 100% <0%> (+9.52%) ⬆️
...s/opentelemetry-tracing/src/BasicTracerRegistry.ts 100% <0%> (ø) ⬆️
... and 117 more

OlivierAlbertini
OlivierAlbertini approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OlivierAlbertini OlivierAlbertini added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 29, 2020
mayurkale22
mayurkale22 approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I remember same thing we did in OC.

@mayurkale22 mayurkale22 added the Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Feb 10, 2020
@dyladan
Copy link
Member Author

dyladan commented Feb 10, 2020

@open-telemetry/javascript-approvers can I get a few more ✅ on this?

@dyladan dyladan merged commit d67cb8c into open-telemetry:master Feb 18, 2020
@dyladan dyladan deleted the jaeger-pad-trace-id branch February 18, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@markwolff markwolff markwolff approved these changes

@OlivierAlbertini OlivierAlbertini OlivierAlbertini approved these changes

@bg451 bg451 Awaiting requested review from bg451

@obecny obecny Awaiting requested review from obecny

@rochdev rochdev Awaiting requested review from rochdev

@vmarchaud vmarchaud Awaiting requested review from vmarchaud

Assignees
No one assigned
Labels
bug Something isn't working Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jaeger traces get right-padded with '0's when used with jaeger propagator
5 participants
@dyladan @codecov-io @OlivierAlbertini @markwolff @mayurkale22