feat(sdk-trace-base): add spanProcessors property in TracerConfig interface
#5138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5138 +/- ##
==========================================
- Coverage 93.21% 93.17% -0.05%
==========================================
Files 315 314 -1
Lines 8096 8076 -20
Branches 1622 1622
==========================================
- Hits 7547 7525 -22
- Misses 549 551 +2
|
4 tasks
pichlermarc
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
just two nits, looks good overall (most of this has been reviewed at #5134 - so I mostly skimmed over it) 🙂
thanks for working on this 🙌
david-luna
changed the title
spanProcessors property in TracerConfig interfacespanProcessors property in TracerConfig interface
4 tasks
This was referenced Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
addSpanProcessorAPI is planned to be removed in the next major version. This PR adds thespanProcessorsconfig option in the tracer provider base class so users can migrate to this new way of configuring the tracer provider.Ref #4792
Short description of the changes
spanProcessorsproperty inTracerConfigBasicTraceProvidet.test.tsto test the new property@opentelemetry/sdk-nodeto use the new constructor APITracerProviderWithEnvExporterclass from@opentelemetry/sdk-node@opentelemetry/sdk-nodetestsType of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: