Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update releasing.md to mention npm publish workflow, fix a link to release PR workflow #5087

Merged
merged 2 commits into from
Nov 4, 2024
Merged

docs: update releasing.md to mention npm publish workflow, fix a link to release PR workflow #5087

merged 2 commits into from
Nov 4, 2024

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

I added another workflow recently #5067 - this PR:

  • adds some instructions for that new workflow, and replaces the old ones
  • adds some extra comments to explain the added workflow from ci: add workflow to publish packages to npm #5067, some things I figured out myself over time and some of the knowledge there was handed down to me a long time ago but never put into writing
  • fixes a broken link for the workflow to create release PRs

How Has This Been Tested?

  • we ran through the flow that's explained here with a subset of @open-telemetry/javascript-maintainers yesterday

@pichlermarc pichlermarc requested a review from a team as a code owner October 24, 2024 12:01
@pichlermarc pichlermarc changed the title Docs/relasing md docs: update releasing.md to mention npm publish workflow, fixes a link to release PR workflow Oct 24, 2024
@pichlermarc pichlermarc changed the title docs: update releasing.md to mention npm publish workflow, fixes a link to release PR workflow docs: update releasing.md to mention npm publish workflow, fix a link to release PR workflow Oct 24, 2024
@pichlermarc pichlermarc added the document Documentation-related label Oct 24, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (eb3ca4f) to head (b922e42).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5087   +/-   ##
=======================================
  Coverage   93.18%   93.18%           
=======================================
  Files         315      315           
  Lines        8086     8086           
  Branches     1617     1617           
=======================================
  Hits         7535     7535           
  Misses        551      551

hectorhdzg
hectorhdzg approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pichlermarc pichlermarc added this pull request to the merge queue Nov 4, 2024
Merged via the queue into open-telemetry:main with commit 4c0921e Nov 4, 2024
22 of 23 checks passed
@pichlermarc pichlermarc deleted the docs/relasing-md branch November 4, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorhdzg hectorhdzg hectorhdzg approved these changes

@maryliag maryliag maryliag approved these changes

@david-luna david-luna david-luna approved these changes

Assignees
No one assigned
Labels
document Documentation-related Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pichlermarc @david-luna @maryliag @hectorhdzg