ci: use codecov token when uploading reports #5053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5053 +/- ##
==========================================
- Coverage 93.39% 93.27% -0.13%
==========================================
Files 46 317 +271
Lines 712 8194 +7482
Branches 120 1640 +1520
==========================================
+ Hits 665 7643 +6978
- Misses 47 551 +504 |
trentm
approved these changes
Oct 8, 2024
yep, i checked before opening this PR. It's defined at the org level and inherited by this repo 🙂 |
Merged
via the queue into
open-telemetry:main
with commit Oct 9, 2024
859c0ef
21 of 22 checks passed
Annosha
pushed a commit
to Annosha/opentelemetry-js
that referenced
this pull request
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Noticed that all the PR states that the coverage from
mainis behind. Looks like on main the permissions are not enough to create a new main commit in codecov.So I'm now passing the token to see if that makes a difference. This is what the Go SIG does:
https://github.com/open-telemetry/opentelemetry-go/blob/8fbaa970843f0899228bc19c1e45a31f5a5bb73e/.github/workflows/ci.yml#L124-L130
See:
I've noticed the same happening on contrib, where we're hundreds of commits behind. We'll have to do the same there.