fix(resources): wait for async attributes for detecting resources #4687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziolekjj
changed the title
maryliag
approved these changes
Jun 4, 2024
|
Hey @pichlermarc, sorry for mentioning you; I'm not sure who would be the best person to ask for a review here, It still requires a code owner approval, is everything good here? I am happy to help with pushing this forward |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
any update for this MR? today i'm using this workaround: #4638 (comment) but after the merge of this change, i would like to remove them. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4687 +/- ##
==========================================
+ Coverage 93.26% 93.27% +0.01%
==========================================
Files 317 317
Lines 8194 8195 +1
Branches 1640 1641 +1
==========================================
+ Hits 7642 7644 +2
+ Misses 552 551 -1
|
david-luna
approved these changes
Oct 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Failure on |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Annosha
pushed a commit
to Annosha/opentelemetry-js
that referenced
this pull request
Oct 19, 2024
…en-telemetry#4687) Co-authored-by: David Luna <david.luna@elastic.co>
pxaws
added a commit
to aws-observability/aws-otel-js-instrumentation
that referenced
this pull request
Oct 30, 2024
*Issue #, if available:* *Description of changes:* Due to a [bug](open-telemetry/opentelemetry-js#4687) in upstream, the `detectResourcesSync` doesn't wait for the async attributes. This happens if we use the async version of some resource detector. The [fix](open-telemetry/opentelemetry-js#4687) is in another upstream release. We don't want to upgrade the upstream version for now. To avoid this issue, we switch to the sync version of the detectors and this should have no impact for the functionalities (as `detectResourcesSync` waits for all async detectors anyway and works for both sync and async detectors). In the future, even if we upgrade upstream version, we don't need to switch back to async detectors. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Recently,
HostDetectorwas added as default for detectors inNodeSDK, this produces the error message:Accessing resource attributes before async attributes settled, asdetectResourcesSyncis not waiting for async attributes to be resolved forHostDetector, what causes the lack ofmachine_idpassed to it.Fixes #4638
Short description of the changes
I've updated the test case for the issue and added an await statement to wait for async attributes to be resolved for the
detectResourcesSyncfunction.Type of change
How Has This Been Tested?
I've added unit tests, the configuration for reproducing is described in the linked issue #4638