-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lerna): add lerna-changelog #432
chore(lerna): add lerna-changelog #432
Conversation
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
==========================================
+ Coverage 95.81% 95.87% +0.06%
==========================================
Files 108 108
Lines 5278 5315 +37
Branches 433 428 -5
==========================================
+ Hits 5057 5096 +39
+ Misses 221 219 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
RELEASING.md
Outdated
Pass your github token to generate the changelog automatically. | ||
In your terminal, execute the following command: | ||
```bash | ||
GITHUB_AUTH=xxxxx lerna-changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this require a GitHub token? I would have expected it to be able to get the commit info simply from the git history, or is it pulling pull request info as well?
Could we at least ask people to use a read-only token?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this require a GitHub token?
For rate limiting issues. Sadly, it's required...
or is it pulling pull request info as well?
It will use pull request info
Also, it will print changelog for PR that have been labelled (see lerna.json)
Could we at least ask people to use a read-only token?
Yes. Good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, makes sense!
closes open-telemetry#372 add docs related to lerna-changelog Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
e5e439d
to
7219008
Compare
* chore(lerna): add lerna-changelog closes open-telemetry#372 add docs related to lerna-changelog Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * fix: add draffensperger recommendations Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Which problem is this PR solving?
Short description of the changes
lerna-changelog
package