Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(instrumentation-grpc): drop support for grpc #3807

Merged
merged 19 commits into from
Jun 12, 2023
Merged

chore(instrumentation-grpc): drop support for grpc #3807

merged 19 commits into from
Jun 12, 2023

Conversation

llc1123
Copy link
Contributor

@llc1123 llc1123 commented May 16, 2023 •
edited
Loading

Which problem is this PR solving?

Dropped support for package grpc (not @grpc-js/grpc) due to deprecation.

Fixes #3780

Short description of the changes

  • Removed grpc example.
  • Dropped support of grpc instrumentation.
  • Fixed a few eslint warnings in instrumentation-grpc

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Existing tests

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@llc1123 llc1123 marked this pull request as ready for review May 16, 2023 09:40
@llc1123 llc1123 requested a review from a team May 16, 2023 09:40
@codecov
Copy link

codecov bot commented May 16, 2023 •
edited
Loading

Codecov Report

Merging #3807 (ee3f1c8) into main (4a7091f) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head ee3f1c8 differs from pull request most recent head 6159018. Consider uploading reports for the commit 6159018 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3807      +/-   ##
==========================================
- Coverage   92.98%   92.89%   -0.09%     
==========================================
  Files         300      297       -3     
  Lines        9104     8836     -268     
  Branches     1862     1814      -48     
==========================================
- Hits         8465     8208     -257     
+ Misses        639      628      -11
Impacted Files Coverage Δ
...elemetry-instrumentation-grpc/src/grpc-js/index.ts 92.74% <ø> (ø)
...emetry-instrumentation-grpc/src/instrumentation.ts 72.72% <ø> (-3.14%) ⬇️
...ry-instrumentation-grpc/src/grpc-js/clientUtils.ts 92.85% <100.00%> (ø)
...es/opentelemetry-instrumentation-grpc/src/utils.ts 82.69% <100.00%> (-11.54%) ⬇️

@llc1123 llc1123 force-pushed the chore/remove-grpc branch from b9d6646 to 5aa59ac Compare May 16, 2023 09:42
dyladan
dyladan approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit

experimental/packages/opentelemetry-instrumentation-grpc/src/grpc-js/clientUtils.ts Outdated Show resolved Hide resolved
@pichlermarc
Copy link
Member

Thanks for removing this. 🙂

We discussed this change in the SIG meeting last week, and figured we would add a postinstall script first to the package to alert users that the grpc-native instrumentaiton is being removed as not to break people in an completely unexpected manner.

So we will hold off on merging this, add a postinstall script warning users that this is about to happen, release, then merge this PR.

@pichlermarc pichlermarc mentioned this pull request May 24, 2023
Merged
9 tasks
@llc1123 llc1123 mentioned this pull request Jun 3, 2023
Closed
6 tasks
pichlermarc
pichlermarc reviewed Jun 7, 2023
View reviewed changes
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current versions of instrumentation-grpc should now have a warning that this will be removed, so this PR should be safe to merge now - just one nit though + request to create a follow-up issue to refactor as some of the code that became unnecessary with this change.

experimental/packages/opentelemetry-instrumentation-grpc/package.json Outdated Show resolved Hide resolved
experimental/packages/opentelemetry-instrumentation-grpc/test/helper.ts Show resolved Hide resolved
@llc1123 llc1123 requested a review from pichlermarc June 7, 2023 08:11
@llc1123 llc1123 force-pushed the chore/remove-grpc branch from 0d4ae85 to 5750d9a Compare June 7, 2023 09:14
@pichlermarc pichlermarc mentioned this pull request Jun 7, 2023
Closed
@pichlermarc pichlermarc merged commit e8540c5 into open-telemetry:main Jun 12, 2023
@llc1123 llc1123 deleted the chore/remove-grpc branch June 12, 2023 12:20
Nico385412 pushed a commit to Nico385412/opentelemetry-js that referenced this pull request Jun 13, 2023
@llc1123 @dyladan @Nico385412
chore(instrumentation-grpc): drop support for grpc (open-telemetry#…
b06762e 
…3807)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
@pichlermarc pichlermarc mentioned this pull request Jul 4, 2023
Merged
@Flarna Flarna mentioned this pull request Oct 12, 2023
Closed
2 tasks
@pichlermarc pichlermarc mentioned this pull request Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svetlanabrennan svetlanabrennan svetlanabrennan approved these changes

@pichlermarc pichlermarc pichlermarc approved these changes

@dyladan dyladan dyladan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for package grpc in instrumentation and examples
4 participants
@llc1123 @pichlermarc @dyladan @svetlanabrennan