Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update CONTRIBUTING.md merge requirements #3671

Merged
merged 3 commits into from
Mar 15, 2023

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Mar 13, 2023

Following a conversation with @martinkuba, I realized the CONTRIBUTING.md did not reflect the policies most recently agreed to in the SIG meetings and implemented in the repository settings. This PR is meant to clarify the merge requirements and who should merge PRs when they are ready.

@dyladan dyladan requested a review from a team March 13, 2023 20:31
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #3671 (f5ca0d5) into main (d82a098) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head f5ca0d5 differs from pull request most recent head 27c14f8. Consider uploading reports for the commit 27c14f8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3671   +/-   ##
=======================================
  Coverage   93.71%   93.71%           
=======================================
  Files         277      277           
  Lines        8448     8451    +3     
  Branches     1754     1755    +1     
=======================================
+ Hits         7917     7920    +3     
  Misses        531      531           
Impacted Files Coverage Δ
...ages/sdk-metrics/src/state/DeltaMetricProcessor.ts 100.00% <100.00%> (ø)

@dyladan dyladan merged commit 3653f5c into open-telemetry:main Mar 15, 2023
@dyladan dyladan deleted the merge-requirements branch March 15, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants