Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): declare this parameter type in observable callbacks #3497

Merged
merged 3 commits into from
Jan 3, 2023
Merged

fix(api): declare this parameter type in observable callbacks #3497

merged 3 commits into from
Jan 3, 2023

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

Fixes #3293

Declare the this parameter types for the observable callbacks.

This should not be a breaking change as usages without this parameter to be the expected one are not working anyways.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Existing code should continue to be able to compile without any touch.

Checklist:

  • Followed the style guidelines of this project

@legendecas legendecas marked this pull request as ready for review December 19, 2022 07:15
@legendecas legendecas requested a review from a team December 19, 2022 07:15
@legendecas legendecas mentioned this pull request Dec 19, 2022
Closed
@codecov
Copy link

codecov bot commented Dec 19, 2022 •
edited
Loading

Codecov Report

Merging #3497 (f904549) into main (eecb800) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3497   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files         249      249           
  Lines        7610     7610           
  Branches     1587     1587           
=======================================
  Hits         7135     7135           
  Misses        475      475

@legendecas legendecas merged commit 93222fc into open-telemetry:main Jan 3, 2023
@legendecas legendecas deleted the api/callback-this branch January 3, 2023 10:44
@dyladan dyladan mentioned this pull request Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pichlermarc pichlermarc pichlermarc approved these changes

@dyladan dyladan dyladan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(metrics-sdk): destructing ObservableResultImpl breaks collecting metrics value
3 participants
@legendecas @dyladan @pichlermarc