Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(otlp-*-exporter-base): add internal use note #3453

Merged

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Nov 30, 2022

Which problem is this PR solving?

It is not clear that the otlp-*-exporter-base packages are not supposed to be installed by users directly. This PR adds a note the package is intended for internal use only, this will then also show up on the package's page on npmjs.com

@pichlermarc pichlermarc added document Documentation-related Skip Changelog labels Nov 30, 2022
@pichlermarc pichlermarc marked this pull request as ready for review November 30, 2022 10:14
@pichlermarc pichlermarc requested a review from a team November 30, 2022 10:14
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #3453 (101618d) into main (369b07e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3453   +/-   ##
=======================================
  Coverage   93.37%   93.37%           
=======================================
  Files         248      248           
  Lines        7547     7547           
  Branches     1574     1574           
=======================================
  Hits         7047     7047           
  Misses        500      500           

@pichlermarc pichlermarc changed the title docs(otlp-exporter-base): add internal use note docs(otlp-*-exporter-base): add internal use note Nov 30, 2022
@vmarchaud vmarchaud merged commit 91f94a8 into open-telemetry:main Dec 4, 2022
@pichlermarc pichlermarc deleted the docs/exporter-base branch December 5, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants