fix(otlp-transformer): remove type dependency on Long #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3022 +/- ##
=======================================
Coverage 92.78% 92.78%
=======================================
Files 185 185
Lines 6144 6144
Branches 1300 1300
=======================================
Hits 5701 5701
Misses 443 443 |
Flarna
approved these changes
Jun 7, 2022
pichlermarc
approved these changes
Jun 7, 2022
rauno56
approved these changes
Jun 7, 2022
|
Long was included here on purpose. When provided with a Long, the protobuf encoder uses it to ensure large numbers are accurate. It is not included by default because of its large payload penalty on browsers. |
|
@dyladan do we have a usage example on this? I didn't find one so it seems like safe to be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #3020
Short description of the changes
We have no usage on types of Long and its implementation. Removing the references in types should not break any usage.
Type of change
Checklist: