chore: remove husky hooks #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flarna
approved these changes
Apr 13, 2022
|
fixes: #2078 |
Codecov Report
@@ Coverage Diff @@
## main #2898 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 165 165
Lines 5605 5605
Branches 1178 1178
=======================================
Hits 5230 5230
Misses 375 375 |
|
Note this might cause confusing errors for people next time they do a full clean and install because the hooks will still exist in their .git directory and will fail because husky binary is missing. The fix is to manually remove all hooks. |
vmarchaud
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2078
Remove husky and commitlint. Now that we're using manual changelogs, we don't need to enforce conventional commits so strictly in this repository. I still think we should strive to use them in PR titles, but I have found myself being mostly annoyed by the enforced hooks and using
--no-verifyflag most of the time.