-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace usages of SpanAttributes
/MetricAttributes
with Attributes
#4175
Comments
SpanAttributes
with Attributes
SpanAttributes
/MetricAttributes
with Attributes
I'll work on this. Working on experimental/packages/opentelemetry-exporter-prometheus/ |
maybe we make this into a checklist so it's easier to track? opentelemetry-exporter-prometheus (#4993)
opentelemetry-instrumentation-fetch (no usages found)
opentelemetry-instrumentation-grpc (no usages found)
opentelemetry-instrumentation-http (#5023)
opentelemetry-instrumentation-xml-http-request
opentelemetry-core (#4408)
opentelemetry-resources (#4428)
sdk-trace-base (#5009)
opentelemetry-semantic-conventions (#4175 (comment))
opentelemetry-shim-opentracing (#4430)
sdk-metrics (#5021)
|
|
I believe Refs: #4428 (comment) |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Adding Marc's comment here because it was a really useful explanation: We're just allowed to bump the API version for all packages except for
What we cannot do on However, there are a few packages where we can actually exchange the
Everything else that does not fit these constraints must be done in the So, to summarize, we can bump and replace
These changes would have to go into the There is a special case with |
In main branch cd experimental/packages/opentelemetry-instrumentation-xml-http-request/
rg SpanAttributes
src/xhr.ts
162: _addFinalSpanAttributes(span: api.Span, xhrMem: XhrMem, spanUrl?: string) {
418: plugin._addFinalSpanAttributes(span, xhrMem, spanUrl);
rg MetricAttributes
# no results
rg ResourceAttributes
# no results
rg SpanAttributeValue
# no results
rg MetricAttributeValue
# no results I think instrumentation-xml-http-request is fine :) |
instrumentation-grpc seems to be clear as well cd experimental/packages/opentelemetry-instrumentation-grpc/
rg SpanAttributes
src/types.ts
27: metadataToSpanAttributes?: {
src/instrumentation.ts
537: config.metadataToSpanAttributes?.client?.requestMetadata ?? []
541: config.metadataToSpanAttributes?.client?.responseMetadata ?? []
547: config.metadataToSpanAttributes?.server?.requestMetadata ?? []
551: config.metadataToSpanAttributes?.server?.responseMetadata ?? []
README.md
54:| [`metadataToSpanAttributes`](https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/packages/opentelemetry-instrumentation-grpc/src/types.ts#L27) | `object` | List of case insensitive metadata to convert to span attributes. Client and server (outgoing requests, incoming responses) metadata attributes will be converted to span attributes in the form of `rpc.{request\response}.metadata.metadata_key`, e.g. `rpc.response.metadata.date` |
test/helper.ts
961: metadataToSpanAttributes: {
test/grpc-protobuf-ts.test.ts
789: metadataToSpanAttributes: {
rg MetricAttributes
# no results
rg ResourceAttributes
# no results
rg SpanAttributeValue
# no results
rg MetricAttributeValue
# no results No types to rename |
instrumentation-fetch too cd experimental/packages/opentelemetry-instrumentation-fetch/
rg SpanAttributes
src/fetch.ts
124: private _addFinalSpanAttributes(
290: this._addFinalSpanAttributes(span, response);
rg MetricAttributes
# no results
rg ResourceAttributes
# no results
rg SpanAttributeValue
# no results
rg MetricAttributeValue
# no results |
@JamieDanielson could I be missing something in my previous comments? with #4978 merged I can go for the http instrumentation :) |
@david-luna yep, I everything seems to be done - thanks for taking care of so many of these. 🙌 |
SpanAttributes
is deprecated, but bumping the minimum API version would be considered breaking. For 2.0 we could replaceSpanAttributes
withAttributes
and bump the minimum API version accordingly.We can do the same with
MetricAttributes
THIS IS A BREAKING CHANGE. PLEASE MAKE PR TO THE
next
BRANCH FOR INCLUSION IN THE 2.0 RELEASEBelow is a list of files with instances of
SpanAttributes
orMetricAttributes
. In each package, the minimum API version should be bumped to1.1.0
(first version with the common definition ofAttributes
) and any instances ofSpanAttributes
orMetricAttributes
should be replaced withAttributes
.Please limit PRs to a single package in order to make them quickly and easily reviewable.
If you are working on one of the below packages, please comment so others know the issue is being worked on.
The text was updated successfully, but these errors were encountered: