otlptracegrpc: Check error on Shutdown in tests #4517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
hanyuancheung and
dmathieu
as code owners
|
@tonisanta PTAL |
dmathieu
approved these changes
Sep 15, 2023
dashpole
approved these changes
Sep 15, 2023
MrAlias
approved these changes
Sep 15, 2023
tonisanta
approved these changes
Sep 15, 2023
|
Hey @pellared, nice catch! For sure will be useful to identify potential issues on those flaky tests |
Codecov Report
@@ Coverage Diff @@
## main #4517 +/- ##
=====================================
Coverage 81.3% 81.3%
=====================================
Files 220 220
Lines 17678 17678
=====================================
+ Hits 14386 14388 +2
+ Misses 2992 2990 -2
Partials 300 300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4506. PS. The test would still fail, but at least the error report would tell us more.
I tried to reproduce the issue on my Windows for almost half an hour but without luck.
I checked all the "cleanup" code and all looks to be cleaned up but I have found places where the cleanup is checked for errors. My assumption is that stopping some client connection returned an error (some transient OS error) and left some hanging goroutine.