Add WithProducer to the prometheus exporter #4473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
dashpole
force-pushed
the
prom_oc_bridge
branch
from
c8a25ca to
05c1ea9
Compare
Codecov Report
@@ Coverage Diff @@
## main #4473 +/- ##
=======================================
- Coverage 81.3% 81.3% -0.1%
=======================================
Files 220 220
Lines 17662 17661 -1
=======================================
- Hits 14370 14369 -1
Misses 2992 2992
Partials 300 300
|
dashpole
added
pkg:exporter:prometheus
MrAlias
approved these changes
Aug 29, 2023
dmathieu
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4471
When we used RegisterProducer, it was possible to call that directly on the manual reader of the prometheus exporter. When we transitioned to WithProducer, that went away. This adds the WithProducer option to the prometheus exporter, and cleans up the unit tests.