Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api(trace): change SpanID to byte array #241

Merged
merged 3 commits into from
Oct 28, 2019
Merged

api(trace): change SpanID to byte array #241

merged 3 commits into from
Oct 28, 2019

Conversation

paivagustavo
Copy link
Member

Fixes #239

rghetia
rghetia reviewed Oct 25, 2019
View reviewed changes
api/core/span_context.go Outdated Show resolved Hide resolved
api/core/span_context.go Outdated Show resolved Hide resolved
rghetia
rghetia approved these changes Oct 26, 2019
View reviewed changes
Copy link
Contributor

@rghetia rghetia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rghetia rghetia merged commit 4e545e2 into open-telemetry:master Oct 28, 2019
@paivagustavo paivagustavo deleted the span-id-as-byte-array branch October 28, 2019 17:35
hstan referenced this pull request in hstan/opentelemetry-go Oct 15, 2020
@MrAlias
Update runtime.go instrumentation Meter name (#241)
9cc7199 
Resolve #240
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rghetia rghetia rghetia approved these changes

@jmacd jmacd jmacd approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@pjanotti pjanotti Awaiting requested review from pjanotti

@sjkaris sjkaris Awaiting requested review from sjkaris

@tedsuo tedsuo Awaiting requested review from tedsuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.

Change SpanID to a byte array
4 participants
@paivagustavo @jmacd @rghetia @pellared