Store current Span instead of local and remote SpanContext in context.Context #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the SpanContext has a remote identifier, storing a Span's SpanContext two separate ways in a Context (one for local another for remote) is unnecessary and adds complication throughout the project when determining heredity of a Span. This moves to storing the Span directly in the Context uniformly (for both local and remote) as current Span. In the process, it updates the getter/setter functionality the `trace` package provides and replaces the distributed heredity logic throughout the project with just using the current Span as the parent if it exists.
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1731 +/- ##
=====================================
Coverage 77.9% 78.0%
=====================================
Files 131 132 +1
Lines 6953 6941 -12
=====================================
- Hits 5422 5417 -5
+ Misses 1281 1274 -7
Partials 250 250
|
Aneurysm9
approved these changes
Mar 26, 2021
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
XSAM
approved these changes
Mar 29, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the SpanContext has a remote identifier, storing a Span's SpanContext two separate ways in a Context (one for local another for remote) is unnecessary and adds complication throughout the project when determining heredity of a Span. This moves to storing the Span directly in the Context uniformly (for both local and remote) as current Span. In the process, it updates the getter/setter functionality in the
tracepackage provides and removes the distributed heredity logic throughout the project with just using the current Span as the parent if it exists.Resolves #1182