Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move unit package out of otel module #1897

Closed
2 tasks done
MrAlias opened this issue May 10, 2021 · 1 comment · Fixed by #1903
Closed
2 tasks done

Move unit package out of otel module #1897

MrAlias opened this issue May 10, 2021 · 1 comment · Fixed by #1903
Assignees
@MrAlias
Milestone
RC1

Comments

@MrAlias
Copy link
Contributor

MrAlias commented May 10, 2021 •
edited
Loading

The unit package is used by the metrics module and is not stable. It needs to be relocated in a different module than otel so that module can be released as 1.0.

  • Determine best place to move the unit package.
  • Move the unit package.
@MrAlias MrAlias added help wanted Extra attention is needed release:1.0.0-rc.1 labels May 10, 2021
@MrAlias MrAlias added this to the RC1 milestone May 10, 2021
@MrAlias
Copy link
Contributor Author

MrAlias commented May 11, 2021

It looks like the unit package can be moved to the metric module:

$ grep -Rn 'go.opentelemetry.io/otel/unit' | grep '\.go:'
unit/doc.go:20:package unit // import "go.opentelemetry.io/otel/unit"
unit/unit.go:15:package unit // import "go.opentelemetry.io/otel/unit"
metric/config.go:18:	"go.opentelemetry.io/otel/unit"
metric/metric.go:22:	"go.opentelemetry.io/otel/unit"
metric/metric_test.go:26:	"go.opentelemetry.io/otel/unit"
bridge/opencensus/exporter.go:34:	"go.opentelemetry.io/otel/unit"
bridge/opencensus/exporter_test.go:36:	"go.opentelemetry.io/otel/unit"

@MrAlias MrAlias self-assigned this May 11, 2021
@MrAlias MrAlias removed the help wanted Extra attention is needed label May 11, 2021
@MrAlias MrAlias mentioned this issue May 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
None yet
Projects
None yet
Milestone
RC1
Development

Successfully merging a pull request may close this issue.

Move the unit package to the metric module MrAlias/opentelemetry-go
1 participant
@MrAlias