[receiver/hostmetrics] Remove redundant usages of metadata.Attribute #9753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metadata.Attributes is not needed in the new metrics builder to build metrics and can be removed. This change removes redundant usages of that structure from hostmetrics receiver. - 1 usage in filesystemscraper/config.go is just incorrect. - Usage of the metadata.Attributes in tests should be replaced with strings to make the tests more independent from metrics builder generator.
dmitryax
force-pushed
the
hostmetrics-remove-attribute-definition
branch
from
ee3c439 to
65b99e8
Compare
djaglowski
approved these changes
May 5, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
…pen-telemetry#9753) metadata.Attributes is not needed in the new metrics builder to build metrics and can be removed. This change removes redundant usages of that structure from hostmetrics receiver. - 1 usage in filesystemscraper/config.go is just incorrect. - Usage of the metadata.Attributes in tests should be replaced with strings to make the tests more independent from metrics builder generator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metadata.Attributes is not needed in the new metrics builder to build metrics and can be removed.
This change removes redundant usages of that structure from hostmetrics receiver.
Link to tracking Issue: #8842