Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase test timeout to 300s to pass opencensus #5470

Merged
merged 1 commit into from
Sep 29, 2021
Merged

increase test timeout to 300s to pass opencensus #5470

merged 1 commit into from
Sep 29, 2021

Conversation

xp-1000
Copy link
Contributor

@xp-1000 xp-1000 commented Sep 28, 2021

Description: Following up #5243 the make commands fails on opencensus receiver caused by timeout.

Link to tracking Issue: #5243 (comment)

Testing: Run make command

Documentation: no change

Additional information: here is an example of duration on my laptop:

time make -C ./receiver/opencensusreceiver test
make: Entering directory '/home/qmanfroi/git/signalfx/opentelemetry-collector-contrib/receiver/opencensusreceiver'
go test -race -timeout 300s --tags=containers_image_openpgp,exclude_graphdriver_btrfs,exclude_graphdriver_devicemapper ./...
ok      github.com/open-telemetry/opentelemetry-collector-contrib/receiver/opencensusreceiver   140.310s
ok      github.com/open-telemetry/opentelemetry-collector-contrib/receiver/opencensusreceiver/internal/ocmetrics        0.329s
ok      github.com/open-telemetry/opentelemetry-collector-contrib/receiver/opencensusreceiver/internal/octrace  0.614s
make: Leaving directory '/home/qmanfroi/git/signalfx/opentelemetry-collector-contrib/receiver/opencensusreceiver'

real    2m21.503s
user    0m4.198s
sys     0m1.047s

here is the specification of my laptop:

  • CPU: Intel(R) Core(TM) i7-8550U CPU
  • Memory: 16GB
  • Disk: PM981 NVMe Samsung 512GB
  • OS: Arch Linux

@xp-1000 xp-1000 requested review from a team and jpkrohling September 28, 2021 08:18
@xp-1000
Copy link
Contributor Author

xp-1000 commented Sep 28, 2021

I am sorry @anuraaga and @codeboten I re-pushed after rebase but forgot my commit so the PR was automatically closed ... #5246
I open this new one

@tigrannajaryan
Copy link
Member

tigrannajaryan commented Sep 29, 2021 •
edited
Loading

github.com/open-telemetry/opentelemetry-collector-contrib/receiver/opencensusreceiver 140.310s

This begs the question of what the opencensusreceiver test are doing for so long. Perhaps time to start highlighting slow tests somehow to keep the total duration under control.

tigrannajaryan
tigrannajaryan approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @xp-1000

@tigrannajaryan tigrannajaryan merged commit 915a67a into open-telemetry:main Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@codeboten codeboten codeboten approved these changes

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

Assignees

@codeboten codeboten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xp-1000 @tigrannajaryan @codeboten