[pkg/ottl] Change context inferrer to use functions and enums as hints #36869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bogdandrutu,
evan-bradley,
kentquirk and
TylerHelmuth
edmocosta
changed the title
ya all the context implementations allowed these paths, but the grammar didn't actually allow you to use them in any statements I don't think. I don't think we need to support a path referencing the entire object higher in the otlp payload. I am ok with removing this capability from our context implementations and making statements like |
…r-fixes' into change-context-inferrer-and-minor-fixes
TylerHelmuth
added
the
Skip Changelog
TylerHelmuth
approved these changes
Dec 18, 2024
|
@evan-bradley since everything is internal and can be refactored later if needed im gonna merge now to keep things moving. |
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
open-telemetry#36869) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR is part of open-telemetry#29017, and a spin-off from open-telemetry#36820. It changes the existing context inferrer logic to also take into consideration the functions and enums used on the statements. (open-telemetry#36820 (comment)) New logic: - Find all `path`, function names(`editor`, `converter`), and `enumSymbol` on the statements - Pick the highest priority context (same existing logic) based on the `path.Context` values - If the chosen context does not support all used functions and enums, it goes through it's lower contexts (wide scope contexts that does support the chosen context as a path context) testing them and choosing the first one that supports them. - If no context that can handle the functions and enums is found, the inference fail and an empty value is returned. The parser collection was adapted to support the new context inferrer configuration requirements. **Other important changes:** Currently, it's possible to have paths to contexts root objects, for example: `set(attributes["body"], resource)`. Given `resource` has no dot separators on the path, the grammar extracts it into the `path.Fields` slice, letting the `path.Context` value empty. Why? This grammar behaviour is still necessary to keep backward compatibility with paths without context, otherwise it would start requiring contexts for all paths independently of the parser configuration. Previous PRs didn't take this edge case into consideration, and a few places needed to be changed to address it: - Context inferrer (`getContextCandidate`) - Parser `prependContextToStatementPaths` function. - Reusable OTTL contexts (`contexts/internal`) (not part of this PR, it will be fixed by open-telemetry#36820) When/If we reach the point to deprecate paths _without_ context, all those conditions can be removed, and the grammar changed to require and extract the `path` context properly. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue open-telemetry#29017 <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests <!--Describe the documentation added.--> #### Documentation No changes <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of #29017, and a spin-off from #36820. It changes the existing context inferrer logic to also take into consideration the functions and enums used on the statements. (#36820 (comment))
New logic:
path, function names(editor,converter), andenumSymbolon the statementspath.ContextvaluesThe parser collection was adapted to support the new context inferrer configuration requirements.
Other important changes:
Currently, it's possible to have paths to contexts root objects, for example:
set(attributes["body"], resource). Givenresourcehas no dot separators on the path, the grammar extracts it into thepath.Fieldsslice, letting thepath.Contextvalue empty. Why? This grammar behaviour is still necessary to keep backward compatibility with paths without context, otherwise it would start requiring contexts for all paths independently of the parser configuration.Previous PRs didn't take this edge case into consideration, and a few places needed to be changed to address it:
getContextCandidate)prependContextToStatementPathsfunction.contexts/internal) (not part of this PR, it will be fixed by [pkg/ottl] Change OTTL contexts to handle paths with context #36820)When/If we reach the point to deprecate paths without context, all those conditions can be removed, and the grammar changed to require and extract the
pathcontext properly.Link to tracking issue
#29017
Testing
Unit tests
Documentation
No changes