Import CheckDoc tool from Core repo, add the doc check in workflow and remove the old dependencies #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove the old one from unit test
Codecov Report
@@ Coverage Diff @@
## main #2698 +/- ##
==========================================
- Coverage 91.47% 91.46% -0.01%
==========================================
Files 439 439
Lines 21855 21855
==========================================
- Hits 19991 19990 -1
- Misses 1394 1395 +1
Partials 470 470
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kisieland
pushed a commit
to kisieland/opentelemetry-collector-contrib
that referenced
this pull request
Mar 16, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
approved these changes
Mar 16, 2021
3 tasks
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
…ove the old one from unit test (#2698)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Import CheckDoc tool from Core repo, add documentation checker in build workflow and remove the old one from unit test.
It is the 2nd PR from open-telemetry/opentelemetry-collector#2703
Link to tracking Issue:
open-telemetry/opentelemetry-collector#2664
Testing:
make allDocumentation:
https://github.com/open-telemetry/opentelemetry-collector/blob/main/cmd/checkdoc/README.md