Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/snmp] Change the types of the Config.{AuthPassword,PrivacyPassword} fields to be of configopaque.String #24064

Merged
merged 2 commits into from
Jul 18, 2023
Merged

[receiver/snmp] Change the types of the Config.{AuthPassword,PrivacyPassword} fields to be of configopaque.String #24064

merged 2 commits into from
Jul 18, 2023

Conversation

mackjmr
Copy link
Member

@mackjmr mackjmr commented Jul 10, 2023

Description:
Split out from: #17353

Link to tracking Issue: #17273

@mackjmr
[receiver/snmp] Change the types of the `Config.{AuthPassword,Privacy…
632141d 
…Password}` fields to be of `configopaque.String`

**Description:**
Split out from: open-telemetry#17353

**Link to tracking Issue:** open-telemetry#17273
@mackjmr mackjmr requested a review from a team July 10, 2023 13:43
@mackjmr mackjmr requested a review from djaglowski as a code owner July 10, 2023 13:43
crobert-1
crobert-1 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration test failure is unrelated to this PR, issue #23267 is open to fix the flaky test.

@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Jul 12, 2023
@codeboten codeboten merged commit f7fbcd2 into open-telemetry:main Jul 18, 2023
@github-actions github-actions bot added this to the next release milestone Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobert-1 crobert-1 crobert-1 approved these changes

@songy23 songy23 songy23 approved these changes

@codeboten codeboten codeboten approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski

@StefanKurek StefanKurek Awaiting requested review from StefanKurek

@tamir-michaeli tamir-michaeli Awaiting requested review from tamir-michaeli

Assignees

@kovrus kovrus

Labels
ready to merge Code review completed; ready to merge by maintainers receiver/snmp
Projects
None yet
Milestone
v0.82.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mackjmr @codeboten @songy23 @crobert-1 @kovrus