extension/{basicauth,bearertoken,oauth2client}: use configopaque.String #17318

gbbr · 2023-01-02T09:41:41Z

runforesight · 2023-01-02T09:42:53Z

Foresight Summary

Major Impacts

build-and-test-windows duration(4 seconds) has decreased 47 minutes 5 seconds compared to main branch avg(47 minutes 9 seconds).

View More Details

⭕ build-and-test-windows workflow has finished in 4 seconds (47 minutes 5 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.

Job	Failed Steps	Tests
windows-unittest-matrix	- 🔗	N/A	See Details
windows-unittest	- 🔗	N/A	See Details

✅ check-links workflow has finished in 58 seconds (3 minutes 4 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.

Job	Failed Steps	Tests
changed files	- 🔗	N/A	See Details
check-links	- 🔗	N/A	See Details

✅ tracegen workflow has finished in 1 minute 10 seconds (3 minutes 20 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.

Job	Failed Steps	Tests
build-dev	- 🔗	N/A	See Details
publish-latest	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details

✅ changelog workflow has finished in 1 minute 53 seconds (6 minutes 40 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.

Job	Failed Steps	Tests
changelog	- 🔗	N/A	See Details

✅ prometheus-compliance-tests workflow has finished in 3 minutes 19 seconds (7 minutes 18 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.

Job	Failed Steps	Tests
prometheus-compliance-tests	- 🔗	✅ 21 ❌ 0 ⏭ 0 🔗	See Details

✅ build-and-test workflow has finished in 36 minutes 9 seconds (23 minutes 35 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.

Job	Failed Steps	Tests
unittest-matrix (1.19, internal)	- 🔗	✅ 597 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, internal)	- 🔗	✅ 597 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, processor)	- 🔗	✅ 1476 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, processor)	- 🔗	✅ 1476 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, extension)	- 🔗	✅ 528 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, extension)	- 🔗	✅ 528 ❌ 0 ⏭ 0 🔗	See Details
correctness-metrics	- 🔗	✅ 2 ❌ 0 ⏭ 0 🔗	See Details
correctness-traces	- 🔗	✅ 17 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, receiver-0)	- 🔗	✅ 2563 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, receiver-0)	- 🔗	✅ 2563 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, exporter)	- 🔗	✅ 2450 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, exporter)	- 🔗	✅ 2450 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, other)	- 🔗	✅ 4395 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, other)	- 🔗	✅ 4395 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, receiver-1)	- 🔗	✅ 1886 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, receiver-1)	- 🔗	✅ 1886 ❌ 0 ⏭ 0 🔗	See Details
integration-tests	- 🔗	✅ 53 ❌ 0 ⏭ 0 🔗	See Details
setup-environment	- 🔗	N/A	See Details
build-examples	- 🔗	N/A	See Details
check-collector-module-version	- 🔗	N/A	See Details
checks	- 🔗	N/A	See Details
check-codeowners	- 🔗	N/A	See Details
lint-matrix (receiver-0)	- 🔗	N/A	See Details
lint-matrix (receiver-1)	- 🔗	N/A	See Details
lint-matrix (processor)	- 🔗	N/A	See Details
lint-matrix (exporter)	- 🔗	N/A	See Details
lint-matrix (extension)	- 🔗	N/A	See Details
lint-matrix (internal)	- 🔗	N/A	See Details
lint-matrix (other)	- 🔗	N/A	See Details
lint	- 🔗	N/A	See Details
unittest (1.19)	- 🔗	N/A	See Details
unittest (1.18)	- 🔗	N/A	See Details
cross-compile (darwin, amd64)	- 🔗	N/A	See Details
cross-compile (darwin, arm64)	- 🔗	N/A	See Details
cross-compile (linux, 386)	- 🔗	N/A	See Details
cross-compile (linux, amd64)	- 🔗	N/A	See Details
cross-compile (linux, arm)	- 🔗	N/A	See Details
cross-compile (linux, arm64)	- 🔗	N/A	See Details
cross-compile (linux, ppc64le)	- 🔗	N/A	See Details
cross-compile (windows, 386)	- 🔗	N/A	See Details
cross-compile (windows, amd64)	- 🔗	N/A	See Details
build-package (deb)	- 🔗	N/A	See Details
build-package (rpm)	- 🔗	N/A	See Details
windows-msi	- 🔗	N/A	See Details
publish-check	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details
publish-dev	- 🔗	N/A	See Details

✅ load-tests workflow has finished in 11 minutes 39 seconds (7 minutes 4 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.

Job	Failed Steps	Tests
loadtest (TestTraceAttributesProcessor)	- 🔗	✅ 3 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestIdleMode)	- 🔗	✅ 1 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceNoBackend10kSPS\|TestTrace1kSPSWithAttrs)	- 🔗	✅ 8 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestMetric10kDPS\|TestMetricsFromFile)	- 🔗	✅ 6 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestMetricResourceProcessor\|TestTrace10kSPS)	- 🔗	✅ 12 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceBallast1kSPSWithAttrs\|TestTraceBallast1kSPSAddAttrs)	- 🔗	✅ 10 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestBallastMemory\|TestLog10kDPS)	- 🔗	✅ 19 ❌ 0 ⏭ 0 🔗	See Details
setup-environment	- 🔗	N/A	See Details

🔎 See details on Foresight

^{*You can configure Foresight comments in your organization settings page.}

gbbr · 2023-01-02T10:07:40Z

Some unrelated tests seem to be failing: #17319

Updates open-telemetry#17273

github-actions · 2023-01-18T05:17:31Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

gbbr · 2023-01-18T09:12:50Z

@mx-psi is there any reason why we are not merging this?

mx-psi

@mx-psi is there any reason why we are not merging this?

No, I usually don't look at PRs that I have not been assigned/requested review to.

But this LGTM

gbbr requested a review from a team January 2, 2023 09:41

gbbr requested a review from jpkrohling as a code owner January 2, 2023 09:41

github-actions bot assigned djaglowski Jan 2, 2023

gbbr mentioned this pull request Jan 2, 2023

[all][meta] Make existing sensitive configuration fields opaque #17273

Closed

45 tasks

github-actions bot added extension/basicauth extension/bearertokenauth extension/oauth2clientauth labels Jan 2, 2023

extension/{basicauth,bearertoken,oauth2client}: use configopaque.String

20a63ce

Updates open-telemetry#17273

gbbr force-pushed the gbbr/opaque/extension-other branch from 9de8e1d to 20a63ce Compare January 3, 2023 12:39

github-actions bot added the Stale label Jan 18, 2023

mx-psi approved these changes Jan 18, 2023

View reviewed changes

mx-psi merged commit 72799c3 into open-telemetry:main Jan 18, 2023

gbbr deleted the gbbr/opaque/extension-other branch January 18, 2023 10:33

plantfansam mentioned this pull request Jul 21, 2023

disregard #24427

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

extension/{basicauth,bearertoken,oauth2client}: use configopaque.String #17318

extension/{basicauth,bearertoken,oauth2client}: use configopaque.String #17318

gbbr commented Jan 2, 2023

runforesight bot commented Jan 2, 2023 •

edited

Loading

`build-and-test-windows` duration(4 seconds) has decreased 47 minutes 5 seconds compared to main branch avg(47 minutes 9 seconds).

⭕ build-and-test-windows workflow has finished in 4 seconds (47 minutes 5 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.

✅ check-links workflow has finished in 58 seconds (3 minutes 4 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.

✅ tracegen workflow has finished in 1 minute 10 seconds (3 minutes 20 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.

✅ changelog workflow has finished in 1 minute 53 seconds (6 minutes 40 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.

✅ prometheus-compliance-tests workflow has finished in 3 minutes 19 seconds (7 minutes 18 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.

✅ build-and-test workflow has finished in 36 minutes 9 seconds (23 minutes 35 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.

✅ load-tests workflow has finished in 11 minutes 39 seconds (7 minutes 4 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.

gbbr commented Jan 2, 2023

github-actions bot commented Jan 18, 2023

gbbr commented Jan 18, 2023

mx-psi left a comment

extension/{basicauth,bearertoken,oauth2client}: use configopaque.String #17318

extension/{basicauth,bearertoken,oauth2client}: use configopaque.String #17318

Conversation

gbbr commented Jan 2, 2023

runforesight bot commented Jan 2, 2023 • edited Loading

Foresight Summary

build-and-test-windows duration(4 seconds) has decreased 47 minutes 5 seconds compared to main branch avg(47 minutes 9 seconds).

⭕ build-and-test-windows workflow has finished in 4 seconds (47 minutes 5 seconds less than main branch avg.) and finished at 3rd Jan, 2023.

✅ check-links workflow has finished in 58 seconds (3 minutes 4 seconds less than main branch avg.) and finished at 3rd Jan, 2023.

✅ tracegen workflow has finished in 1 minute 10 seconds (3 minutes 20 seconds less than main branch avg.) and finished at 3rd Jan, 2023.

✅ changelog workflow has finished in 1 minute 53 seconds (6 minutes 40 seconds less than main branch avg.) and finished at 3rd Jan, 2023.

✅ prometheus-compliance-tests workflow has finished in 3 minutes 19 seconds (7 minutes 18 seconds less than main branch avg.) and finished at 3rd Jan, 2023.

✅ build-and-test workflow has finished in 36 minutes 9 seconds (23 minutes 35 seconds less than main branch avg.) and finished at 3rd Jan, 2023.

✅ load-tests workflow has finished in 11 minutes 39 seconds (7 minutes 4 seconds less than main branch avg.) and finished at 3rd Jan, 2023.

gbbr commented Jan 2, 2023

github-actions bot commented Jan 18, 2023

gbbr commented Jan 18, 2023

mx-psi left a comment

Choose a reason for hiding this comment

runforesight bot commented Jan 2, 2023 •

edited

Loading

`build-and-test-windows` duration(4 seconds) has decreased 47 minutes 5 seconds compared to main branch avg(47 minutes 9 seconds).

⭕ build-and-test-windows workflow has finished in 4 seconds (47 minutes 5 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.

✅ check-links workflow has finished in 58 seconds (3 minutes 4 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.

✅ tracegen workflow has finished in 1 minute 10 seconds (3 minutes 20 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.

✅ changelog workflow has finished in 1 minute 53 seconds (6 minutes 40 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.

✅ prometheus-compliance-tests workflow has finished in 3 minutes 19 seconds (7 minutes 18 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.

✅ build-and-test workflow has finished in 36 minutes 9 seconds (23 minutes 35 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.

✅ load-tests workflow has finished in 11 minutes 39 seconds (7 minutes 4 seconds less than `main` branch avg.) and finished at 3rd Jan, 2023.