[ci] Specify 7 as arm version for arm build in CI #7873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
approved these changes
Jun 11, 2023
codeboten
approved these changes
Jun 12, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #7873 +/- ##
==========================================
- Coverage 91.14% 91.12% -0.03%
==========================================
Files 298 298
Lines 14915 14915
==========================================
- Hits 13594 13591 -3
- Misses 1045 1047 +2
- Partials 276 277 +1 ☔ View full report in Codecov by Sentry. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previously, we introduced linux/arm to the cross build tests in the CI to add an armv7 release.
However, without specifying the
GOARMvariable, it falls back to the default value. The default value is not always7as it depends on the platform that we are building on. There are changes to default to GOARM=7 for all non-arm systems in the upcoming golang versionWe are building on
linux/amd64machine in github action soGOARMdefaults to5which is different from what we want.In this pull request, I added
GOARMas an environment variable andgoarmin the arm matrix option so we can explicit setGOARM=7.Testing:
Able to run
make otelcoreolwith the following configurations locallyGOOS=linux,GOARCH=arm,GOARM=7GOOS=linux,GOARCH=arm64,GOARM=GOOS=darwin,GOARCH=amd64,GOARM=