[chore] move receiver/scrapererror to scraper/scrapererror #11733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11733 +/- ##
=======================================
Coverage 91.45% 91.45%
=======================================
Files 447 447
Lines 23721 23721
=======================================
Hits 21694 21694
Misses 1653 1653
Partials 374 374 ☔ View full report in Codecov by Sentry. |
|
@bogdandrutu @mx-psi if you want to take a look, thank you |
mx-psi
reviewed
Nov 26, 2024
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
mx-psi
approved these changes
Nov 27, 2024
|
@bogdandrutu will merge this next Tuesday unless you comment |
bogdandrutu
approved these changes
Dec 2, 2024
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
…metry#11733) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Migrates existing scrapererror code to new scraper package. Sets aliases for receiver/scrapererror so that dependent code in contrib and elsewhere can be updated <!-- Issue number if applicable --> #### Link to tracking issue Relates to open-telemetry#11003 <!--Describe what testing was performed and which tests were added.--> #### Testing included unit/integration tests should suffice <!--Describe the documentation added.--> #### Documentation changelog yaml <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates existing scrapererror code to new scraper package. Sets aliases for receiver/scrapererror so that dependent code in contrib and elsewhere can be updated
Link to tracking issue
Relates to #11003
Testing
included unit/integration tests should suffice
Documentation
changelog yaml