Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] MMCV maximum_version set to 1.6 #1480

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

MeowZheng
Copy link
Collaborator

@MeowZheng MeowZheng commented Apr 15, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

as title

Modification

  1. revise mmcv max version in mmseg/init.py
  2. revise mmcv max version in requirements/mminstall.txt
  3. revise mmcv max version install documentation

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #1480 (11d8798) into master (737e7e6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1480   +/-   ##
=======================================
  Coverage   90.28%   90.28%           
=======================================
  Files         139      139           
  Lines        8313     8313           
  Branches     1398     1398           
=======================================
  Hits         7505     7505           
  Misses        570      570           
  Partials      238      238           
Flag Coverage Δ
unittests 90.28% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/__init__.py 90.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 737e7e6...11d8798. Read the comment docs.

@MeowZheng MeowZheng merged commit 618d3c3 into open-mmlab:master Apr 19, 2022
@MeowZheng MeowZheng deleted the mmcv-version branch April 19, 2022 08:19
ZhimingNJ pushed a commit to AetrexTechnology/mmsegmentation that referenced this pull request Jun 29, 2022
* [Enhancement] MMCV maximum_version set to 1.6

* [Enhancement] MMCV maximum_version set to 1.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants