Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix max_coordinate in multiclass_nms_rotated #346

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Conversation

liuyanyi
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

fix max_coordinate in multiclass_nms_rotated

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #346 (8b09126) into main (ff6d407) will decrease coverage by 1.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
- Coverage   31.94%   30.86%   -1.08%     
==========================================
  Files         113      119       +6     
  Lines        7394     7934     +540     
  Branches     1135     1220      +85     
==========================================
+ Hits         2362     2449      +87     
- Misses       4931     5384     +453     
  Partials      101      101              
Flag Coverage Δ
unittests 30.84% <0.00%> (-1.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrotate/core/post_processing/bbox_nms_rotated.py 6.15% <0.00%> (ø)
mmrotate/models/losses/__init__.py 100.00% <0.00%> (ø)
mmrotate/core/bbox/coder/__init__.py 100.00% <0.00%> (ø)
mmrotate/models/detectors/__init__.py 100.00% <0.00%> (ø)
mmrotate/models/dense_heads/__init__.py 100.00% <0.00%> (ø)
...ate/models/dense_heads/rotated_anchor_free_head.py 22.58% <0.00%> (ø)
mmrotate/models/dense_heads/rotated_fcos_head.py 10.04% <0.00%> (ø)
...rotate/models/dense_heads/csl_rotated_fcos_head.py 13.88% <0.00%> (ø)
mmrotate/models/detectors/rotated_fcos.py 83.33% <0.00%> (ø)
mmrotate/models/losses/rotated_iou_loss.py 25.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff6d407...8b09126. Read the comment docs.

Copy link
Collaborator

@zytx121 zytx121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne ZwwWayne merged commit e22c8df into open-mmlab:main Jun 15, 2022
This was referenced Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants