Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo about split gap of ms #272

Merged
merged 3 commits into from
Jun 6, 2022
Merged

Conversation

zytx121
Copy link
Collaborator

@zytx121 zytx121 commented May 1, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The split gap of ms should be 500, not 200.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@zytx121 zytx121 changed the title Fix typo about MS gap Fix typo about split gap of ms May 1, 2022
@codecov
Copy link

codecov bot commented May 1, 2022

Codecov Report

Merging #272 (343c72b) into dev (3055b56) will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #272      +/-   ##
==========================================
+ Coverage   31.59%   31.94%   +0.34%     
==========================================
  Files         113      113              
  Lines        7355     7394      +39     
  Branches     1128     1135       +7     
==========================================
+ Hits         2324     2362      +38     
- Misses       4929     4931       +2     
+ Partials      102      101       -1     
Flag Coverage Δ
unittests 31.91% <ø> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrotate/datasets/builder.py 45.45% <0.00%> (-6.40%) ⬇️
mmrotate/datasets/hrsc.py 18.03% <0.00%> (ø)
mmrotate/datasets/pipelines/transforms.py 82.94% <0.00%> (+2.64%) ⬆️
mmrotate/datasets/dota.py 73.68% <0.00%> (+3.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b04a80...343c72b. Read the comment docs.

@zytx121 zytx121 requested a review from yangxue0827 May 2, 2022 02:29
@zytx121 zytx121 requested review from jbwang1997 and liuyanyi June 5, 2022 06:50
@zytx121 zytx121 mentioned this pull request Jun 5, 2022
Copy link
Collaborator

@liuyanyi liuyanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@yangxue0827 yangxue0827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jbwang1997 jbwang1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Jun 6, 2022

lint failure

@ZwwWayne ZwwWayne merged commit 5f7d50d into open-mmlab:dev Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants