Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix typo in Config File and Model Zoo #199

Merged
merged 4 commits into from
Apr 29, 2022

Conversation

nijkah
Copy link
Contributor

@nijkah nijkah commented Apr 10, 2022

Motivation

Fix typo in config file and model zoo.

Modification

Fix typo in config file and model zoo.

@nijkah nijkah changed the base branch from main to dev April 10, 2022 09:37
@zytx121
Copy link
Collaborator

zytx121 commented Apr 13, 2022

Yes, It's my mistake. However, the typo should be MS+RR -> MS. And could you fix the same typo in docs/zh_cn/model_zoo.md? (no chinese in this part.)

ignore.

@nijkah
Copy link
Contributor Author

nijkah commented Apr 13, 2022

@zytx121 But in the log it seems to use PolyRandomRotate in the config file.
The config file seems to have same data configuration as in redet_re50_refpn_1x_dota_ms_rr_le90.
Am I missing some points?

@zytx121
Copy link
Collaborator

zytx121 commented Apr 13, 2022

@zytx121 But in the log it seems to use PolyRandomRotate in the config file. The config file seems to have same data configuration as in redet_re50_refpn_1x_dota_ms_rr_le90. Am I missing some points?

I checked it again. You are right, it should be MS+RR.

@zytx121
Copy link
Collaborator

zytx121 commented Apr 13, 2022

Could you fix the same typo in configs/roi_trans/README.md and docs/zh_cn/model_zoo.md?

@codecov-commenter
Copy link

Codecov Report

Merging #199 (2c94c50) into dev (44b0aec) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #199      +/-   ##
==========================================
- Coverage   28.30%   28.29%   -0.02%     
==========================================
  Files         108      108              
  Lines        6967     6967              
  Branches     1048     1048              
==========================================
- Hits         1972     1971       -1     
  Misses       4927     4927              
- Partials       68       69       +1     
Flag Coverage Δ
unittests 28.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrotate/datasets/builder.py 48.14% <0.00%> (-3.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b0aec...2c94c50. Read the comment docs.

Copy link
Collaborator

@zytx121 zytx121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zytx121 zytx121 mentioned this pull request Apr 28, 2022
@ZwwWayne ZwwWayne merged commit 0c28088 into open-mmlab:dev Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants