-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Refactor unittest of RuntimeInfohook
#810
Merged
zhouzaida
merged 2 commits into
open-mmlab:refactor_hooks_unittest
from
HAOCHENYE:HAOCHENYE/refactor_unittest_runtimeinfohook
Dec 22, 2022
Merged
[Refactor] Refactor unittest of RuntimeInfohook
#810
zhouzaida
merged 2 commits into
open-mmlab:refactor_hooks_unittest
from
HAOCHENYE:HAOCHENYE/refactor_unittest_runtimeinfohook
Dec 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAOCHENYE
force-pushed
the
HAOCHENYE/refactor_unittest_runtimeinfohook
branch
from
December 10, 2022 14:13
db9fae5
to
27b5825
Compare
zhouzaida
reviewed
Dec 21, 2022
zhouzaida
reviewed
Dec 21, 2022
zhouzaida
reviewed
Dec 21, 2022
This PR can be merged after resolving the above comments. |
zhouzaida
approved these changes
Dec 22, 2022
HAOCHENYE
added a commit
that referenced
this pull request
Feb 21, 2023
* Refactor RuntimeInfoHook * Fix as comment
Merged
HAOCHENYE
added a commit
that referenced
this pull request
Feb 21, 2023
* Refactor RuntimeInfoHook * Fix as comment
zhouzaida
pushed a commit
that referenced
this pull request
Feb 21, 2023
* Refactor RuntimeInfoHook * Fix as comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist