[Refactor] Refactor logger hook unittest #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAOCHENYE
changed the title
HAOCHENYE
force-pushed
the
HAOCHENYE/refactor_logger_hook_unittest
branch
from
3e7d5b5 to
1e4bdb9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #797 +/- ##
=======================================
Coverage ? 76.61%
=======================================
Files ? 138
Lines ? 10866
Branches ? 2177
=======================================
Hits ? 8325
Misses ? 2185
Partials ? 356
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
HAOCHENYE
changed the title
C1rN09
reviewed
Jan 17, 2023
C1rN09
previously approved these changes
Jan 30, 2023
HAOCHENYE
force-pushed
the
refactor_hooks_unittest
branch
3 times, most recently
from
30f11d5 to
32e2ef0
Compare
Co-authored-by: Qian Zhao <112053249+C1rN09@users.noreply.github.com>
HAOCHENYE
force-pushed
the
HAOCHENYE/refactor_logger_hook_unittest
branch
from
c94baaf to
7c9992d
Compare
zhouzaida
reviewed
Feb 28, 2023
zhouzaida
reviewed
Feb 28, 2023
zhouzaida
reviewed
Feb 28, 2023
zhouzaida
reviewed
Feb 28, 2023
zhouzaida
reviewed
Feb 28, 2023
zhouzaida
reviewed
Feb 28, 2023
zhouzaida
reviewed
Feb 28, 2023
zhouzaida
reviewed
Feb 28, 2023
zhouzaida
reviewed
Mar 1, 2023
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
…gger_hook_unittest
zhouzaida
reviewed
Apr 5, 2023
zhouzaida
reviewed
Apr 5, 2023
…HAOCHENYE/mmengine into HAOCHENYE/refactor_logger_hook_unittest
…gger_hook_unittest
zhouzaida
reviewed
Apr 5, 2023
zhouzaida
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist