[Fix] Fix creating a new logger at PretrainedInit #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAOCHENYE
reviewed
Dec 6, 2022
mmengine/model/weight_init.py
Outdated
| @@ -481,7 +481,7 @@ def __call__(self, module): | |||
| from mmengine.runner.checkpoint import (_load_checkpoint_with_prefix, | |||
| load_checkpoint, | |||
| load_state_dict) | |||
| logger = MMLogger.get_instance('mmengine') | |||
| logger = MMLogger.get_current_instance() | |||
There was a problem hiding this comment.
We can directly call print_log(xxx, logger='current') here, and do not need to get the current logger here.
zhouzaida
previously approved these changes
Dec 6, 2022
MengzhangLI
previously approved these changes
Dec 7, 2022
zhouzaida
reviewed
Dec 11, 2022
mmengine/runner/checkpoint.py
Outdated
Comment on lines
110
to
113
| elif logger is not None: | ||
| logger.warning(err_msg) | ||
| else: | ||
| print(err_msg) | ||
| print_log(err_msg, logger='current', level=logging.WARNING) |
There was a problem hiding this comment.
elif logger is not None:
logger.warning(err_msg)
else:
print_log(err_msg, logger='current', level=logging.WARNING)->
else:
print_log(err_msg, logger=logger, level=logging.WARNING)
zhouzaida
reviewed
Dec 11, 2022
mmengine/model/weight_init.py
Outdated
| state_dict = _load_checkpoint_with_prefix( | ||
| self.prefix, self.checkpoint, map_location=self.map_location) | ||
| load_state_dict(module, state_dict, strict=False, logger=logger) | ||
| load_state_dict(module, state_dict, strict=False) |
There was a problem hiding this comment.
Suggested change
| load_state_dict(module, state_dict, strict=False) | |
| load_state_dict(module, state_dict, strict=False, logger='current') |
zhouzaida
reviewed
Dec 11, 2022
mmengine/model/weight_init.py
Outdated
| load_checkpoint( | ||
| module, | ||
| self.checkpoint, | ||
| map_location=self.map_location, | ||
| strict=False, | ||
| logger=logger) | ||
| strict=False) |
There was a problem hiding this comment.
Suggested change
| strict=False) | |
| strict=False, | |
| logger='current') |
zhouzaida
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
When training with a pre-trained model, MMEngine will create a new logger.
Modification
Use
MMLogger.get_current_instance()instead ofMMLogger.get_instance('mmengine')BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.