Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhance] Support flat param decay mult and fix bias decay mult of depth-wise conv. #771

Merged
merged 6 commits into from
Dec 16, 2022
Merged

[Enhance] Support flat param decay mult and fix bias decay mult of depth-wise conv. #771

merged 6 commits into from
Dec 16, 2022

Conversation

RangiLyu
Copy link
Member

@RangiLyu RangiLyu commented Nov 28, 2022 •
edited
Loading

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

  1. Support adjust weight decay multiplier of flat params.
  2. The optim wrapper constructor cannot set dwconv's bias decay multiplier.

Modification

  1. Add flat_decay_mult in paramwise_cfg.
  2. Fix the order of judging bias and dwconv.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

TODO

  • Unit tests

@RangiLyu RangiLyu requested a review from mzr1996 November 28, 2022 02:20
HAOCHENYE
HAOCHENYE previously approved these changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@HAOCHENYE HAOCHENYE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!!!
image

@HAOCHENYE HAOCHENYE added the enhancement New feature or request label Nov 30, 2022
@RangiLyu RangiLyu added the WIP label Nov 30, 2022
@RangiLyu RangiLyu changed the title [Fix] Fix bias decay mult of depth-wise conv. [Enhance] Support flat param decay mult and fix bias decay mult of depth-wise conv. Nov 30, 2022
@RangiLyu RangiLyu removed the WIP label Dec 8, 2022
@RangiLyu RangiLyu requested a review from HAOCHENYE December 8, 2022 07:43
@RangiLyu RangiLyu requested a review from HAOCHENYE December 9, 2022 09:02
HAOCHENYE
HAOCHENYE previously approved these changes Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@HAOCHENYE HAOCHENYE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!!!
image

@codecov
Copy link

codecov bot commented Dec 9, 2022 •
edited
Loading

Codecov Report

Base: 78.66% // Head: 78.66% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (c0c9a96) compared to base (fe26c65).
Patch coverage: 90.47% of modified lines in pull request are covered.

❗ Current head c0c9a96 differs from pull request most recent head 7fabb40. Consider uploading reports for the commit 7fabb40 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #771      +/-   ##
==========================================
- Coverage   78.66%   78.66%   -0.01%     
==========================================
  Files         128      128              
  Lines        9348     9355       +7     
  Branches     1848     1851       +3     
==========================================
+ Hits         7354     7359       +5     
  Misses       1679     1679              
- Partials      315      317       +2
Flag Coverage Δ
unittests 78.66% <90.47%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmengine/visualization/visualizer.py 93.19% <ø> (ø)
mmengine/optim/optimizer/optimizer_wrapper.py 62.06% <71.42%> (-0.44%) ⬇️
mmengine/optim/optimizer/default_constructor.py 98.27% <100.00%> (+0.04%) ⬆️
mmengine/optim/optimizer/optimizer_wrapper_dict.py 98.50% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mzr1996
mzr1996 previously approved these changes Dec 12, 2022
View reviewed changes
@zhouzaida
Copy link
Collaborator

This PR can be merged after resolving the above comment.

@CLAassistant
Copy link

CLAassistant commented Dec 14, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@RangiLyu RangiLyu dismissed stale reviews from mzr1996 and HAOCHENYE via 47c4bfa December 15, 2022 03:02
@RangiLyu RangiLyu requested a review from C1rN09 as a code owner December 15, 2022 03:02
@RangiLyu RangiLyu requested a review from HAOCHENYE December 15, 2022 03:03
@HAOCHENYE HAOCHENYE added the ready ready to merge label Dec 15, 2022
@HAOCHENYE HAOCHENYE added this to the 0.4.0 milestone Dec 16, 2022
@zhouzaida zhouzaida merged commit 3582b4c into open-mmlab:main Dec 16, 2022
RangiLyu added a commit to RangiLyu/mmengine that referenced this pull request Dec 19, 2022
@RangiLyu
[Enhance] Support setting decay multiplier for flatten parameter (ope…
5c10502 
…n-mmlab#771)

* [Fix] Fix bias decay mult of depth-wise conv.

* support flatten param weight decay multiplier

* add unit tests

* REMOVE TODO

* update doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouzaida zhouzaida zhouzaida approved these changes

@HAOCHENYE HAOCHENYE HAOCHENYE approved these changes

@mzr1996 mzr1996 mzr1996 left review comments

@C1rN09 C1rN09 Awaiting requested review from C1rN09

Assignees

@HAOCHENYE HAOCHENYE

Labels
enhancement New feature or request ready ready to merge
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@RangiLyu @zhouzaida @CLAassistant @mzr1996 @HAOCHENYE