fix add_config func is not called bug #613
Conversation
fix wandb add_config bug add wandb log_code feature
shenmishajing
requested review from
Harold-lkk,
HAOCHENYE,
zhouzaida and
RangiLyu
as code owners
|
Hi @shenmishajing , thanks for your contribution. It would make the code more robust if unit tests are added for those modifications. |
add log_code_name param to docstring
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
…into fix_add_config_is_not_called_bug
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
add PATH_FILTERS registry
|
@zhouzaida How about this? I add a registry name PATH_FILTERS to specific the include_fn and exclude_fn. |
add PATH_FILTERS registry
|
Sorry, I may have misrepresented it, what I was trying to say was that you could follow your previous solution and not support include_func and exclude_func. |
@zhouzaida Oh……I'm sorry I ignore the |
Suggest rolling it back. |
@zhouzaida Got it. |
* fix add_config func is not called bug fix wandb add_config bug add wandb log_code feature * move log_code_name param to the last one add log_code_name param to docstring * add config only when there is a cfg Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com> * add unit test for log_code_name param of WandbVisBackend * Update mmengine/visualization/vis_backend.py Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com> * use log_code_kwargs instead of only log_code_name add PATH_FILTERS registry * use log_code_kwargs instead of only log_code_name add PATH_FILTERS registry * fix add config unit test * roll back to log_code_name version Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Motivation
The add_config func of visualizer is not called, so all vis_backends will not get the configs.
call
self.visualizer.add_config(self.cfg)after create visualizer.The add_config func of wandb is wrong, see https://docs.wandb.ai/guides/track/config
wandb add_config by
wandb.config.update(<a dict object here>)instead ofwandb.save()In addition, wandb can log all codes to reproduce experiments, I add this feature in add_config func.
Modification
call
self.visualizer.add_config(self.cfg)after create visualizer.fix wandb add_config bug by
wandb.config.update(<a dict object here>)instead ofwandb.save()add wandb log_code feature
Use cases (Optional)
set the log_code_name of WandbVisBackend to named code artifacts.
Checklist