-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] support registering partial functions and more #595
[Feature] support registering partial functions and more #595
Conversation
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #595 +/- ##
=======================================
Coverage 78.10% 78.11%
=======================================
Files 126 126
Lines 9039 9042 +3
Branches 1800 1800
=======================================
+ Hits 7060 7063 +3
Misses 1666 1666
Partials 313 313
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
aae512e
to
0f652bd
Compare
a78b95d
to
9998486
Compare
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
This PR is converted to DRAFT because I think this may break the design of
Registry
and may mess up some concept. I will re-examine the necessity and rationality of this change.Support registering partial functions in MMEngine, solve #594
This feature might be required by FSDP for
auto_wrap_policies
Modification
modify
Registry
to accept allCallable
, including classes, functions, partial functions and moreBC-breaking (Optional)
No
Use cases (Optional)
Checklist